lock names: Remove uid suffix & hash entire path

[tstromberg]

This PR makes lock names unique again for Windows users.

Currently, we generate lock names by taking the last 39 characters of:

fmt.Sprintf("%s-%s", path, uid))

On most platforms, uid's are 0-6 characters long. However, on Windows, a SID is returned, which looks like:

S-1-5-21-1180699209-877415012-3182924384-1004

That's 46 characters long. Effectively, on Windows, all of our locks shared the same name:

m21-1180699209-877415012-3182924384

Why was the UID added anyways? Because we used to assign lock names based on a descripter, like "kubeConfig", and we wanted multiple users to be able to run minikube simultaneously. Now that we only generate locks on a path name, this is no longer necessary, as we actually do want to lock a file if multiple users try to update it.

Fixes #6058

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tstromberg]

/ok-to-test

[minikube-bot]

Error: running mkcmp: exit status 1

[codecov-io]

Codecov Report

Merging #6059 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##           master   #6059      +/-   ##
=========================================
- Coverage   36.74%   36.7%   -0.04%     
=========================================
  Files         113     113              
  Lines        8366    8355      -11     
=========================================
- Hits         3074    3067       -7     
+ Misses       4890    4887       -3     
+ Partials      402     401       -1

Impacted Files	Coverage Δ
pkg/minikube/kubeconfig/settings.go	64.81% <100%> (ø)	⬆️
pkg/minikube/bootstrapper/certs.go	75.25% <100%> (ø)	⬆️
pkg/util/lock/lock.go	41.17% <33.33%> (-8.83%)	⬇️

[minikube-bot]

All Times minikube: [ 127.604308 130.908744 127.251100]
All Times Minikube (PR 6059): [ 127.944323 128.706528 125.571980]

Average minikube: 128.588051
Average Minikube (PR 6059): 127.407610

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6059) |
+----------------------+-----------+--------------------+
| minikube v           |  0.278992 |           0.279004 |
| Creating kvm2        | 49.790154 |          48.040097 |
| Preparing Kubernetes | 51.770099 |          51.245501 |
| Pulling images       |  2.765938 |           3.389353 |
| Launching Kubernetes | 21.337014 |          21.485065 |
| Waiting for cluster  |  2.596055 |           2.917906 |
+----------------------+-----------+--------------------+

[minikube-bot]

All Times minikube: [ 126.190235 126.979790 128.087883]
All Times Minikube (PR 6059): [ 128.101241 125.874494 127.215820]

Average minikube: 127.085969
Average Minikube (PR 6059): 127.063851

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6059) |
+----------------------+-----------+--------------------+
| minikube v           |  0.274026 |           0.276365 |
| Creating kvm2        | 48.627733 |          47.296535 |
| Preparing Kubernetes | 51.345713 |          52.086880 |
| Pulling images       |  3.098376 |           3.161714 |
| Launching Kubernetes | 20.958029 |          21.447277 |
| Waiting for cluster  |  2.732127 |           2.745347 |
+----------------------+-----------+--------------------+

[medyagh]

maybe add a description to the PR that why you think it fixes the issue ?

[sharifelgamal]

ok to test

[minikube-bot]

All Times minikube: [ 129.505926 126.133423 113.651865]
All Times Minikube (PR 6059): [ 127.121494 127.868825 127.814676]

Average minikube: 123.097071
Average Minikube (PR 6059): 127.601665

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6059) |
+----------------------+-----------+--------------------+
| minikube v           |  0.282188 |           0.283870 |
| Creating kvm2        | 48.525958 |          47.563997 |
| Preparing Kubernetes | 48.113624 |          52.490516 |
| Pulling images       |  3.028203 |           3.159913 |
| Launching Kubernetes | 20.477955 |          21.155682 |
| Waiting for cluster  |  2.619155 |           2.895266 |
+----------------------+-----------+--------------------+

[minikube-bot]

All Times minikube: [ 132.483634 125.859874 127.080990]
All Times Minikube (PR 6059): [ 113.841001 125.400895 127.009401]

Average minikube: 128.474833
Average Minikube (PR 6059): 122.083766

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6059) |
+----------------------+-----------+--------------------+
| minikube v           |  0.275496 |           0.278832 |
| Creating kvm2        | 48.901489 |          47.157970 |
| Preparing Kubernetes | 52.357620 |          48.457573 |
| Pulling images       |  2.736398 |           2.919455 |
| Launching Kubernetes | 21.242898 |          20.589065 |
| Waiting for cluster  |  2.910510 |           2.630382 |
+----------------------+-----------+--------------------+

[sharifelgamal]

I like this a lot more conceptually.