Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --interactive flag to prevent stdin prompts #5397

Merged
merged 6 commits into from
Sep 18, 2019

Conversation

tstromberg
Copy link
Contributor

(need to verify on kvm2 and update tests)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 18, 2019
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.18.0'
golangci/golangci-lint info found version: 1.18.0 for v1.18.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
test/integration/driver_install_or_update_test.go:150:67: cannot use dir (variable of type string) as bool value in argument to drivers.InstallOrUpdate (typecheck)
		err = drivers.InstallOrUpdate("docker-machine-driver-hyperkit", dir, newerVersion)
		                                                                ^
test/integration/fn_mount_cmd.go:39:2: U1000: const `guestMount` is unused (unused)
	guestMount                = "/mount-9p"
	^
test/integration/fn_mount_cmd.go:40:2: U1000: const `createdByPod` is unused (unused)
	createdByPod              = "created-by-pod"
	^
test/integration/fn_mount_cmd.go:41:2: U1000: const `createdByTest` is unused (unused)
	createdByTest             = "created-by-test"
	^
test/integration/fn_mount_cmd.go:42:2: U1000: const `createdByTestRemovedByPod` is unused (unused)
	createdByTestRemovedByPod = "created-by-test-removed-by-pod"
	^
test/integration/fn_mount_cmd.go:43:2: U1000: const `createdByPodRemovedByTest` is unused (unused)
	createdByPodRemovedByTest = "created-by-pod-removed-by-test"
	^
test/integration/fn_mount_cmd.go:46:6: U1000: func `validateMountCmd` is unused (unused)
func validateMountCmd(ctx context.Context, t *testing.T, profile string) {
     ^
test/integration/fn_pvc.go:36:6: U1000: func `validatePersistentVolumeClaim` is unused (unused)
func validatePersistentVolumeClaim(ctx context.Context, t *testing.T, profile string) {
     ^
test/integration/fn_tunnel_cmd.go:40:6: U1000: func `validateTunnelCmd` is unused (unused)
func validateTunnelCmd(ctx context.Context, t *testing.T, profile string) {
     ^
test/integration/main.go:38:5: U1000: var `testdataDir` is unused (unused)
var testdataDir = flag.String("testdata-dir", "testdata", "the directory relative to test/integration where the testdata lives")
    ^
Makefile:335: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.083s	coverage: 16.0% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.057s	coverage: 18.7% of statements
ok  	k8s.io/minikube/pkg/drivers	0.014s	coverage: 12.4% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.051s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.035s	coverage: 61.8% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	3.089s	coverage: 73.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.056s	coverage: 30.6% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.287s	coverage: 53.0% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.023s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.024s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.007s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.053s	coverage: 75.9% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.029s	coverage: 1.4% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.041s	coverage: 11.3% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.020s	coverage: 78.6% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.008s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.006s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.009s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.019s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.032s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/sshutil	0.205s	coverage: 75.0% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.012s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.990s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	1.620s	coverage: 62.0% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.004s	coverage: 59.1% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.002s	coverage: 0.0% of statements
ok
Makefile:232: recipe for target 'test' failed
make: *** [test] Error 4
TravisBuddy Request Identifier: b8e80e60-da52-11e9-b256-8f6de709717d

@tstromberg tstromberg changed the title WIP: Add --interactive flag support Add --interactive flag to prevent stdin prompts Sep 18, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2019
@tstromberg tstromberg merged commit 2526a9c into kubernetes:master Sep 18, 2019
@TravisBuddy
Copy link

Hey @tstromberg,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 220aaae0-da64-11e9-b256-8f6de709717d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants