Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove heapster addon #5243

Merged
merged 2 commits into from
Nov 6, 2019
Merged

Conversation

rajalokan
Copy link
Contributor

Fixes #5017. As per discussion, needed a rebase and this PR is rebased
to latest master.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @rajalokan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rajalokan
To complete the pull request process, please assign afbjorklund
You can assign the PR to them by writing /assign @afbjorklund in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@TravisBuddy
Copy link

Travis tests have failed

Hey @rajalokan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.17.1'
golangci/golangci-lint info found version: 1.17.1 for v1.17.1/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
ok
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ERROR: logging before flag.Parse: I0902 09:43:04.176070   10617 vm_assets.go:204] Created asset deploy/addons/addon-manager.yaml.tmpl with 1452 bytes
ERROR: logging before flag.Parse: I0902 09:43:04.176307   10617 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-dp.yaml.tmpl with 1605 bytes
ERROR: logging before flag.Parse: I0902 09:43:04.176384   10617 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-svc.yaml.tmpl with 979 bytes
ERROR: logging before flag.Parse: I0902 09:43:04.176434   10617 vm_assets.go:204] Created asset deploy/addons/storageclass/storageclass.yaml.tmpl with 271 bytes
ERROR: logging before flag.Parse: I0902 09:43:04.176640   10617 vm_assets.go:204] Created asset deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl with 1755 bytes
ERROR: logging before flag.Parse: I0902 09:43:04.176673   10617 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-gluster-ns.yaml.tmpl with 230 bytes
ERROR: logging before flag.Parse: I0902 09:43:04.176758   10617 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/glusterfs-daemonset.yaml.tmpl with 3935 bytes
ERROR: logging before flag.Parse: I0902 09:43:04.176840   10617 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/heketi-deployment.yaml.tmpl with 4045 bytes
ERROR: logging before flag.Parse: I0902 09:43:04.176901   10617 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-provisioner-glusterfile.yaml.tmpl with 3236 bytes
panic: Failed to define asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl: Asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl not found

goroutine 1 [running]:
k8s.io/minikube/pkg/minikube/assets.MustBinAsset(0x1b37c3f, 0x32, 0x1b006e2, 0x16, 0x1affbae, 0x15, 0x1ae3f3c, 0x4, 0x1, 0xc000349bc0)
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/vm_assets.go:156 +0x1ab
k8s.io/minikube/pkg/minikube/assets.init.ializers()
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/addons.go:135 +0x11ca
FAIL	k8s.io/minikube/cmd/minikube/cmd	0.018s
ERROR: logging before flag.Parse: I0902 09:43:10.206598   10830 vm_assets.go:204] Created asset deploy/addons/addon-manager.yaml.tmpl with 1452 bytes
ERROR: logging before flag.Parse: I0902 09:43:10.206811   10830 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-dp.yaml.tmpl with 1605 bytes
ERROR: logging before flag.Parse: I0902 09:43:10.206873   10830 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-svc.yaml.tmpl with 979 bytes
ERROR: logging before flag.Parse: I0902 09:43:10.206926   10830 vm_assets.go:204] Created asset deploy/addons/storageclass/storageclass.yaml.tmpl with 271 bytes
ERROR: logging before flag.Parse: I0902 09:43:10.207100   10830 vm_assets.go:204] Created asset deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl with 1755 bytes
ERROR: logging before flag.Parse: I0902 09:43:10.207138   10830 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-gluster-ns.yaml.tmpl with 230 bytes
ERROR: logging before flag.Parse: I0902 09:43:10.207230   10830 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/glusterfs-daemonset.yaml.tmpl with 3935 bytes
ERROR: logging before flag.Parse: I0902 09:43:10.207320   10830 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/heketi-deployment.yaml.tmpl with 4045 bytes
ERROR: logging before flag.Parse: I0902 09:43:10.207398   10830 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-provisioner-glusterfile.yaml.tmpl with 3236 bytes
panic: Failed to define asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl: Asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl not found

goroutine 1 [running]:
k8s.io/minikube/pkg/minikube/assets.MustBinAsset(0x196047c, 0x32, 0x192def3, 0x16, 0x192d565, 0x15, 0x1914310, 0x4, 0x1, 0xc000361bc0)
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/vm_assets.go:156 +0x1ab
k8s.io/minikube/pkg/minikube/assets.init.ializers()
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/addons.go:135 +0x11ca
FAIL	k8s.io/minikube/cmd/minikube/cmd/config	0.019s
ok  	k8s.io/minikube/pkg/drivers	0.012s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.027s	coverage: 2.3% of statements
ERROR: logging before flag.Parse: I0902 09:43:13.821742   11063 vm_assets.go:204] Created asset deploy/addons/addon-manager.yaml.tmpl with 1452 bytes
ERROR: logging before flag.Parse: I0902 09:43:13.822057   11063 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-dp.yaml.tmpl with 1605 bytes
ERROR: logging before flag.Parse: I0902 09:43:13.822125   11063 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-svc.yaml.tmpl with 979 bytes
ERROR: logging before flag.Parse: I0902 09:43:13.822162   11063 vm_assets.go:204] Created asset deploy/addons/storageclass/storageclass.yaml.tmpl with 271 bytes
ERROR: logging before flag.Parse: I0902 09:43:13.822383   11063 vm_assets.go:204] Created asset deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl with 1755 bytes
ERROR: logging before flag.Parse: I0902 09:43:13.822468   11063 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-gluster-ns.yaml.tmpl with 230 bytes
ERROR: logging before flag.Parse: I0902 09:43:13.822549   11063 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/glusterfs-daemonset.yaml.tmpl with 3935 bytes
ERROR: logging before flag.Parse: I0902 09:43:13.822637   11063 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/heketi-deployment.yaml.tmpl with 4045 bytes
ERROR: logging before flag.Parse: I0902 09:43:13.822733   11063 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-provisioner-glusterfile.yaml.tmpl with 3236 bytes
panic: Failed to define asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl: Asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl not found

goroutine 1 [running]:
k8s.io/minikube/pkg/minikube/assets.MustBinAsset(0x10b2f81, 0x32, 0x109602d, 0x16, 0x1095a14, 0x15, 0x10847c9, 0x4, 0x105a101, 0xc000357c80)
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/vm_assets.go:156 +0x1bd
k8s.io/minikube/pkg/minikube/assets.init.ializers()
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/addons.go:135 +0x11ca
FAIL	k8s.io/minikube/pkg/minikube/assets	0.025s
ERROR: logging before flag.Parse: I0902 09:43:17.853774   11239 vm_assets.go:204] Created asset deploy/addons/addon-manager.yaml.tmpl with 1452 bytes
ERROR: logging before flag.Parse: I0902 09:43:17.854008   11239 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-dp.yaml.tmpl with 1605 bytes
ERROR: logging before flag.Parse: I0902 09:43:17.854083   11239 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-svc.yaml.tmpl with 979 bytes
ERROR: logging before flag.Parse: I0902 09:43:17.854169   11239 vm_assets.go:204] Created asset deploy/addons/storageclass/storageclass.yaml.tmpl with 271 bytes
ERROR: logging before flag.Parse: I0902 09:43:17.854338   11239 vm_assets.go:204] Created asset deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl with 1755 bytes
ERROR: logging before flag.Parse: I0902 09:43:17.854393   11239 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-gluster-ns.yaml.tmpl with 230 bytes
ERROR: logging before flag.Parse: I0902 09:43:17.854538   11239 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/glusterfs-daemonset.yaml.tmpl with 3935 bytes
ERROR: logging before flag.Parse: I0902 09:43:17.854677   11239 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/heketi-deployment.yaml.tmpl with 4045 bytes
ERROR: logging before flag.Parse: I0902 09:43:17.854791   11239 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-provisioner-glusterfile.yaml.tmpl with 3236 bytes
panic: Failed to define asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl: Asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl not found

goroutine 1 [running]:
k8s.io/minikube/pkg/minikube/assets.MustBinAsset(0x1145086, 0x32, 0x11261fd, 0x16, 0x1125b38, 0x15, 0x1113a57, 0x4, 0xc0003ca001, 0xc000341c20)
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/vm_assets.go:156 +0x1ab
k8s.io/minikube/pkg/minikube/assets.init.ializers()
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/addons.go:135 +0x11ca
FAIL	k8s.io/minikube/pkg/minikube/bootstrapper	0.019s
ERROR: logging before flag.Parse: I0902 09:43:25.347684   11414 vm_assets.go:204] Created asset deploy/addons/addon-manager.yaml.tmpl with 1452 bytes
ERROR: logging before flag.Parse: I0902 09:43:25.347971   11414 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-dp.yaml.tmpl with 1605 bytes
ERROR: logging before flag.Parse: I0902 09:43:25.348060   11414 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-svc.yaml.tmpl with 979 bytes
ERROR: logging before flag.Parse: I0902 09:43:25.348150   11414 vm_assets.go:204] Created asset deploy/addons/storageclass/storageclass.yaml.tmpl with 271 bytes
ERROR: logging before flag.Parse: I0902 09:43:25.348313   11414 vm_assets.go:204] Created asset deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl with 1755 bytes
ERROR: logging before flag.Parse: I0902 09:43:25.348420   11414 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-gluster-ns.yaml.tmpl with 230 bytes
ERROR: logging before flag.Parse: I0902 09:43:25.348559   11414 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/glusterfs-daemonset.yaml.tmpl with 3935 bytes
ERROR: logging before flag.Parse: I0902 09:43:25.348720   11414 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/heketi-deployment.yaml.tmpl with 4045 bytes
ERROR: logging before flag.Parse: I0902 09:43:25.348835   11414 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-provisioner-glusterfile.yaml.tmpl with 3236 bytes
panic: Failed to define asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl: Asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl not found

goroutine 1 [running]:
k8s.io/minikube/pkg/minikube/assets.MustBinAsset(0x199a2cb, 0x32, 0x1969180, 0x16, 0x19687dd, 0x15, 0x194f9f7, 0x4, 0x1, 0xc000096a20)
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/vm_assets.go:156 +0x1ab
k8s.io/minikube/pkg/minikube/assets.init.ializers()
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/addons.go:135 +0x11ca
FAIL	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.030s
ERROR: logging before flag.Parse: I0902 09:43:27.710750   11471 vm_assets.go:204] Created asset deploy/addons/addon-manager.yaml.tmpl with 1452 bytes
ERROR: logging before flag.Parse: I0902 09:43:27.711119   11471 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-dp.yaml.tmpl with 1605 bytes
ERROR: logging before flag.Parse: I0902 09:43:27.711231   11471 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-svc.yaml.tmpl with 979 bytes
ERROR: logging before flag.Parse: I0902 09:43:27.711306   11471 vm_assets.go:204] Created asset deploy/addons/storageclass/storageclass.yaml.tmpl with 271 bytes
ERROR: logging before flag.Parse: I0902 09:43:27.711511   11471 vm_assets.go:204] Created asset deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl with 1755 bytes
ERROR: logging before flag.Parse: I0902 09:43:27.711586   11471 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-gluster-ns.yaml.tmpl with 230 bytes
ERROR: logging before flag.Parse: I0902 09:43:27.711716   11471 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/glusterfs-daemonset.yaml.tmpl with 3935 bytes
ERROR: logging before flag.Parse: I0902 09:43:27.711900   11471 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/heketi-deployment.yaml.tmpl with 4045 bytes
ERROR: logging before flag.Parse: I0902 09:43:27.712013   11471 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-provisioner-glusterfile.yaml.tmpl with 3236 bytes
panic: Failed to define asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl: Asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl not found

goroutine 1 [running]:
k8s.io/minikube/pkg/minikube/assets.MustBinAsset(0x11fe27c, 0x32, 0x11dc88a, 0x16, 0x11dc1af, 0x15, 0x11c862d, 0x4, 0x203001, 0xc000498060)
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/vm_assets.go:156 +0x1ab
k8s.io/minikube/pkg/minikube/assets.init.ializers()
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/addons.go:135 +0x11ca
FAIL	k8s.io/minikube/pkg/minikube/cluster	0.035s
ok  	k8s.io/minikube/pkg/minikube/config	0.027s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.017s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.008s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.061s	coverage: 75.6% of statements
ERROR: logging before flag.Parse: I0902 09:43:33.586658   11689 vm_assets.go:204] Created asset deploy/addons/addon-manager.yaml.tmpl with 1452 bytes
ERROR: logging before flag.Parse: I0902 09:43:33.587034   11689 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-dp.yaml.tmpl with 1605 bytes
ERROR: logging before flag.Parse: I0902 09:43:33.587094   11689 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-svc.yaml.tmpl with 979 bytes
ERROR: logging before flag.Parse: I0902 09:43:33.587128   11689 vm_assets.go:204] Created asset deploy/addons/storageclass/storageclass.yaml.tmpl with 271 bytes
ERROR: logging before flag.Parse: I0902 09:43:33.587344   11689 vm_assets.go:204] Created asset deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl with 1755 bytes
ERROR: logging before flag.Parse: I0902 09:43:33.587381   11689 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-gluster-ns.yaml.tmpl with 230 bytes
ERROR: logging before flag.Parse: I0902 09:43:33.587473   11689 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/glusterfs-daemonset.yaml.tmpl with 3935 bytes
ERROR: logging before flag.Parse: I0902 09:43:33.587557   11689 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/heketi-deployment.yaml.tmpl with 4045 bytes
ERROR: logging before flag.Parse: I0902 09:43:33.587626   11689 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-provisioner-glusterfile.yaml.tmpl with 3236 bytes
panic: Failed to define asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl: Asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl not found

goroutine 1 [running]:
k8s.io/minikube/pkg/minikube/assets.MustBinAsset(0x109961a, 0x32, 0x107c45d, 0x16, 0x107be1a, 0x15, 0x106ab6e, 0x4, 0xc00036de01, 0xc00008c8a0)
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/vm_assets.go:156 +0x1ab
k8s.io/minikube/pkg/minikube/assets.init.ializers()
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/addons.go:135 +0x11ca
FAIL	k8s.io/minikube/pkg/minikube/logs	0.029s
ERROR: logging before flag.Parse: I0902 09:43:37.238426   11750 vm_assets.go:204] Created asset deploy/addons/addon-manager.yaml.tmpl with 1452 bytes
ERROR: logging before flag.Parse: I0902 09:43:37.238639   11750 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-dp.yaml.tmpl with 1605 bytes
ERROR: logging before flag.Parse: I0902 09:43:37.238705   11750 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-svc.yaml.tmpl with 979 bytes
ERROR: logging before flag.Parse: I0902 09:43:37.238771   11750 vm_assets.go:204] Created asset deploy/addons/storageclass/storageclass.yaml.tmpl with 271 bytes
ERROR: logging before flag.Parse: I0902 09:43:37.238933   11750 vm_assets.go:204] Created asset deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl with 1755 bytes
ERROR: logging before flag.Parse: I0902 09:43:37.238980   11750 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-gluster-ns.yaml.tmpl with 230 bytes
ERROR: logging before flag.Parse: I0902 09:43:37.239083   11750 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/glusterfs-daemonset.yaml.tmpl with 3935 bytes
ERROR: logging before flag.Parse: I0902 09:43:37.239185   11750 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/heketi-deployment.yaml.tmpl with 4045 bytes
ERROR: logging before flag.Parse: I0902 09:43:37.239261   11750 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-provisioner-glusterfile.yaml.tmpl with 3236 bytes
panic: Failed to define asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl: Asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl not found

goroutine 1 [running]:
k8s.io/minikube/pkg/minikube/assets.MustBinAsset(0x11fac34, 0x32, 0x11d9208, 0x16, 0x11d8aee, 0x15, 0x11c56f8, 0x4, 0x1, 0xc000343ce0)
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/vm_assets.go:156 +0x1ab
k8s.io/minikube/pkg/minikube/assets.init.ializers()
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/addons.go:135 +0x11ca
FAIL	k8s.io/minikube/pkg/minikube/machine	0.017s
ok  	k8s.io/minikube/pkg/minikube/notify	0.040s	coverage: 81.5% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.021s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.010s	coverage: 42.9% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.008s	coverage: 67.3% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.019s	coverage: 81.8% of statements
ERROR: logging before flag.Parse: I0902 09:43:49.102893   12166 vm_assets.go:204] Created asset deploy/addons/addon-manager.yaml.tmpl with 1452 bytes
ERROR: logging before flag.Parse: I0902 09:43:49.103134   12166 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-dp.yaml.tmpl with 1605 bytes
ERROR: logging before flag.Parse: I0902 09:43:49.103229   12166 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-svc.yaml.tmpl with 979 bytes
ERROR: logging before flag.Parse: I0902 09:43:49.103280   12166 vm_assets.go:204] Created asset deploy/addons/storageclass/storageclass.yaml.tmpl with 271 bytes
ERROR: logging before flag.Parse: I0902 09:43:49.103496   12166 vm_assets.go:204] Created asset deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl with 1755 bytes
ERROR: logging before flag.Parse: I0902 09:43:49.103596   12166 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-gluster-ns.yaml.tmpl with 230 bytes
ERROR: logging before flag.Parse: I0902 09:43:49.103684   12166 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/glusterfs-daemonset.yaml.tmpl with 3935 bytes
ERROR: logging before flag.Parse: I0902 09:43:49.103777   12166 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/heketi-deployment.yaml.tmpl with 4045 bytes
ERROR: logging before flag.Parse: I0902 09:43:49.103854   12166 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-provisioner-glusterfile.yaml.tmpl with 3236 bytes
panic: Failed to define asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl: Asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl not found

goroutine 1 [running]:
k8s.io/minikube/pkg/minikube/assets.MustBinAsset(0x19270d2, 0x32, 0x18f6a30, 0x16, 0x18f60cc, 0x15, 0x18dda64, 0x4, 0xc00005e201, 0xc0000c4840)
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/vm_assets.go:156 +0x1ab
k8s.io/minikube/pkg/minikube/assets.init.ializers()
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/addons.go:135 +0x11ca
FAIL	k8s.io/minikube/pkg/minikube/service	0.040s
ok  	k8s.io/minikube/pkg/minikube/sshutil	0.123s	coverage: 75.0% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.011s	coverage: 8.4% of statements
ERROR: logging before flag.Parse: I0902 09:43:55.354778   12270 vm_assets.go:204] Created asset deploy/addons/addon-manager.yaml.tmpl with 1452 bytes
ERROR: logging before flag.Parse: I0902 09:43:55.355031   12270 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-dp.yaml.tmpl with 1605 bytes
ERROR: logging before flag.Parse: I0902 09:43:55.355165   12270 vm_assets.go:204] Created asset deploy/addons/dashboard/dashboard-svc.yaml.tmpl with 979 bytes
ERROR: logging before flag.Parse: I0902 09:43:55.355238   12270 vm_assets.go:204] Created asset deploy/addons/storageclass/storageclass.yaml.tmpl with 271 bytes
ERROR: logging before flag.Parse: I0902 09:43:55.355440   12270 vm_assets.go:204] Created asset deploy/addons/storage-provisioner/storage-provisioner.yaml.tmpl with 1755 bytes
ERROR: logging before flag.Parse: I0902 09:43:55.355525   12270 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-gluster-ns.yaml.tmpl with 230 bytes
ERROR: logging before flag.Parse: I0902 09:43:55.355651   12270 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/glusterfs-daemonset.yaml.tmpl with 3935 bytes
ERROR: logging before flag.Parse: I0902 09:43:55.355780   12270 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/heketi-deployment.yaml.tmpl with 4045 bytes
ERROR: logging before flag.Parse: I0902 09:43:55.355905   12270 vm_assets.go:204] Created asset deploy/addons/storage-provisioner-gluster/storage-provisioner-glusterfile.yaml.tmpl with 3236 bytes
panic: Failed to define asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl: Asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl not found

goroutine 1 [running]:
k8s.io/minikube/pkg/minikube/assets.MustBinAsset(0x188181e, 0x32, 0x1850800, 0x16, 0x184fe9c, 0x15, 0x18377c7, 0x4, 0x203001, 0xc0000969c0)
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/vm_assets.go:156 +0x1ab
k8s.io/minikube/pkg/minikube/assets.init.ializers()
	/home/travis/gopath/src/github.com/kubernetes/minikube/pkg/minikube/assets/addons.go:135 +0x11ca
FAIL	k8s.io/minikube/pkg/minikube/tunnel	0.022s
ok  	k8s.io/minikube/pkg/util	1.698s	coverage: 61.6% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.007s	coverage: 59.1% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.002s	coverage: 0.0% of statements
Makefile:229: recipe for target 'test' failed
make: *** [test] Error 16
TravisBuddy Request Identifier: 2ef9c570-cd66-11e9-a9d8-278aeb0f3435

@tstromberg
Copy link
Contributor

make test fails:

panic: Failed to define asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl: Asset deploy/addons/heapster/influx-grafana-rc.yaml.tmpl not found

@tstromberg
Copy link
Contributor

Any luck sorting out the test failure?

You should be able to confirm it locally by running:

make test

@rajalokan
Copy link
Contributor Author

rajalokan commented Sep 6, 2019 via email

@rajalokan
Copy link
Contributor Author

Hi @tstromberg Can you please take a look when you can.

@woodcockjosh
Copy link
Contributor

woodcockjosh commented Oct 1, 2019

@rajalokan please rebase from origin/master and resolve conflicts

@rajalokan
Copy link
Contributor Author

@woodcockjosh Done. Thanks for the review.

@codecov-io
Copy link

codecov-io commented Oct 3, 2019

Codecov Report

Merging #5243 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5243      +/-   ##
==========================================
- Coverage   38.06%   37.83%   -0.24%     
==========================================
  Files         103      103              
  Lines        7540     7589      +49     
==========================================
+ Hits         2870     2871       +1     
- Misses       4293     4341      +48     
  Partials      377      377
Impacted Files Coverage Δ
pkg/minikube/assets/addons.go 36.66% <ø> (ø) ⬆️
cmd/minikube/cmd/config/addons.go 0% <ø> (ø) ⬆️
cmd/minikube/cmd/config/config.go 10.41% <ø> (ø) ⬆️
cmd/minikube/cmd/config/profile_list.go 5.26% <0%> (-2.74%) ⬇️
cmd/minikube/cmd/start.go 22% <0%> (-0.64%) ⬇️

@rajalokan
Copy link
Contributor Author

/assign rajalokan

@sharifelgamal
Copy link
Collaborator

@minikube-bot OK to test

@sharifelgamal sharifelgamal changed the title removes heapster Remove heapster addon Oct 9, 2019
@sharifelgamal
Copy link
Collaborator

This PR looks ready to merge, just needs one fix. Change the removes heapster commit message to something that doesn't start with "removes" using git amend and push. Once that's done I'll merge this.

@rajalokan rajalokan force-pushed the remove-heapster branch 2 times, most recently from 4f3e3f6 to 7328332 Compare October 10, 2019 16:07
Fixes kubernetes#5017. As per discussion, needed a rebase and this PR is rebased
to latest master.
@rajalokan
Copy link
Contributor Author

@sharifelgamal Can you please take a look.

@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 64f1e73 Addon heaspter is not in use

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove heapster addon - it's retired.
8 participants