Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tunnel integration tests for driver None #4105

Merged
merged 6 commits into from
Apr 25, 2019
Merged

fix tunnel integration tests for driver None #4105

merged 6 commits into from
Apr 25, 2019

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Apr 17, 2019 •
edited
Loading

Just need to add some more waiting in the integration test. Functionally everything was sound. Now the integration test waits up to 1 minute to see if the service ingress IP gets patched by minikube tunnel. Fixes #3873.

@balopat balopat added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 17, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2019
@RA489
Copy link

RA489 commented Apr 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: balopat, RA489

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@balopat
Copy link
Contributor Author

balopat commented Apr 24, 2019

@minikube-bot OK to test

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2019
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2019
@balopat balopat added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2019
@balopat balopat merged commit 3ebb16c into kubernetes:master Apr 25, 2019
@balopat balopat mentioned this pull request Apr 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees

@RA489 RA489

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestFunctional/Tunnel on none: svc should have ingress after tunnel is created, but it was empty!
4 participants
@balopat @RA489 @k8s-ci-robot @tstromberg