Fixed status checking with non-default apiserver-port. #4058
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @moduspwnens. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
|
Can one of the admins verify this patch? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: moduspwnens If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @tstromberg |
| @@ -55,6 +55,9 @@ func TestStartStop(t *testing.T) { | |||
| "--extra-config", | |||
| "kubeadm.ignore-preflight-errors=SystemVerification", | |||
| }}, | |||
| {"apiserver_port_non_default", []string{ | |||
| "--apiserver-port=8444", | |||
There was a problem hiding this comment.
Do you mind combining this with another test entry - such as "containerd"?
This is less than ideal, but each entry adds about 10 minutes to our integration tests.
There was a problem hiding this comment.
No problem. I've now pushed a new commit that combines the two tests.
|
@minikube-bot OK to test |
|
Looks great. Thank you! |
This is a fix for #4057.
Component health checking as part of "start" and "status" now respect non-default apiserver port settings from the command line and kubeconfig file, respectively. The functionality is now verified with an integration test.