Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default Kubernetes version to v1.14.0 #3967

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Update default Kubernetes version to v1.14.0 #3967

merged 1 commit into from
Mar 26, 2019

Conversation

tstromberg
Copy link
Contributor

No description provided.

@tstromberg tstromberg added this to the v1.0.0 milestone Mar 26, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2019
@tstromberg
Copy link
Contributor Author

Linux tests failed due to the installed kubectl being too old.

@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

2 similar comments
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg
Copy link
Contributor Author

Worrying bugs:

    --- FAIL: TestFunctional/Provisioning (107.86s)
        pv_test.go:67: no default storage class after retry: No default StorageClass yet.
        util.go:295: Temporary Error: error running command [delete pvc testpvc]: exit status 1. Stdout: 
             Error from server (NotFound): persistentvolumeclaims "testpvc" not found
            
        util.go:295: Temporary Error: error running command [delete pvc testpvc]: exit status 1. Stdout: 
             Error from server (NotFound): persistentvolumeclaims "testpvc" not found
            
        util.go:295: Temporary Error: error running command [delete pvc testpvc]: exit status 1. Stdout: 
             Error from server (NotFound): persistentvolumeclaims "testpvc" not found
            
        pv_test.go:47: delete pvc testpvc failed: Temporary Error: error running command [delete pvc testpvc]: exit status 1. Stdout: 
             Error from server (NotFound): persistentvolumeclaims "testpvc" not found
            
            Temporary Error: error running command [delete pvc testpvc]: exit status 1. Stdout: 
             Error from server (NotFound): persistentvolumeclaims "testpvc" not found
            
            Temporary Error: error running command [delete pvc testpvc]: exit status 1. Stdout: 
             Error from server (NotFound): persistentvolumeclaims "testpvc" not found
            
            output: Error from server (NotFound): persistentvolumeclaims "testpvc" not found
            
    --- FAIL: TestFunctional/Dashboard (180.00s)
        addons_test.go:88: failed to read url: timeout after 3m0s

@tstromberg tstromberg added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2019
@tstromberg tstromberg changed the title Update default Kubernetes version to v1.14.0 WIP: Update default Kubernetes version to v1.14.0 Mar 26, 2019
@tstromberg tstromberg mentioned this pull request Mar 26, 2019
Closed
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg tstromberg changed the title WIP: Update default Kubernetes version to v1.14.0 Update default Kubernetes version to v1.14.0 Mar 26, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2019
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@tstromberg
Copy link
Contributor Author

Failed test is unrelated issue: #3873

balopat
balopat approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@tstromberg tstromberg merged commit e57189a into kubernetes:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tstromberg @k8s-ci-robot @balopat