Run poweroff before delete, only call uninstall if driver is None #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
tstromberg
changed the title
|
@minikube-bot OK to test |
tstromberg
changed the title
tstromberg
changed the title
tstromberg
changed the title
|
@minikube-bot OK to test |
donmccasland
approved these changes
Feb 14, 2019
donmccasland
approved these changes
Feb 14, 2019
donmccasland
approved these changes
Feb 14, 2019
donmccasland
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps hypervisors like HyperV which have issues turning machines off via ACPI by powering the guest off first. This also skips the new "kubeadm reset" uninstall during deletion if the driver isn't none, since the VM is about to be destroyed anyways.
🛑 Powering off "runtimes-crio" via SSH ...
🔥 Deleting "runtimes-crio" from virtualbox ...
💔 The "runtimes-crio" cluster is now deleted. I hope you are happy.
Resolves #2914