Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux install: Set owner to root #2961

Closed
wants to merge 1 commit into from
Closed

Linux install: Set owner to root #2961

wants to merge 1 commit into from

Conversation

aude
Copy link
Contributor

@aude aude commented Jul 4, 2018

Previously, files installed to /usr/local/bin/ would be owned by the user executing the command, not root. This change makes these installed files owned by root instead. Improving security is the goal.

I've updated all install references I found, though there might be places I missed. So do tell if you know any I missed.

Previously, files installed to /usr/local/bin/ would be owned by the
user executing the command, not root. This change makes these installed
files owned by root instead. Improving security is the goal.
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aude
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmidyson

Assign the PR to them by writing /assign @jimmidyson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 4, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@aude
Copy link
Contributor Author

aude commented Jul 4, 2018

Quite discouraging to contribute with this CLA system. I've had no success so far creating an account for the aude@users.noreply.github.com email I used in the commit. I'll see if I can manage to sign it the next few days.

@dlorenc
Copy link
Contributor

dlorenc commented Jul 9, 2018

Closing, please reopen if you can sign the CLA.

@dlorenc dlorenc closed this Jul 9, 2018
@aude
Copy link
Contributor Author

aude commented Jul 9, 2018

I searched the commit log, and found one other recent commit made with a @users.noreply.github.com email address: #2893.

@commitay, it would be super helpful if you'd like to share how you signed the CLA using the email address commitay@users.noreply.github.com.

Other than that, I'm giving it one last go via CNCF helpdesk. Will update this pull request if it's successful.

@aude
Copy link
Contributor Author

aude commented Jul 10, 2018

Signed.

@aude
Copy link
Contributor Author

aude commented Jul 10, 2018

I've signed the CLA.

To continue this pull request we need to do this:

  1. Make sure HEAD in my repo is unchanged from when pull request was closed.
  2. Reopen pull request.
  3. Change author email.
  4. git push --force

Explanation of why: isaacs/github#361

I've done 0. @dlorenc, can you do 1.? Then I'll do 2. and 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants