Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon] Update heapster to v1.5.0 #2182

Merged
merged 1 commit into from
Nov 16, 2017
Merged

[addon] Update heapster to v1.5.0 #2182

merged 1 commit into from
Nov 16, 2017

Conversation

kairen
Copy link
Contributor

@kairen kairen commented Nov 10, 2017

Update heapster to v1.5.0, and fix some YAML fields. This PR has tested on upstream localkube, more detail as below:

$ ./out/minikube addons enable heapster
heapster was successfully enabled

$ kubectl -n kube-system get po,svc
NAME                             READY     STATUS    RESTARTS   AGE
po/heapster-2chhx                1/1       Running   0          1m
po/influxdb-grafana-5qzh8        2/2       Running   0          1m
po/kube-addon-manager-minikube   1/1       Running   0          1h
po/kube-dns-86f6f55dd5-tnssj     3/3       Running   0          1h
po/storage-provisioner           1/1       Running   0          1h

NAME                      TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)             AGE
svc/heapster              ClusterIP   10.103.226.188   <none>        80/TCP              1m
svc/kube-dns              ClusterIP   10.96.0.10       <none>        53/UDP,53/TCP       1h
svc/monitoring-grafana    NodePort    10.104.237.56    <none>        80:30002/TCP        1m
svc/monitoring-influxdb   ClusterIP   10.111.229.93    <none>        8083/TCP,8086/TCP   1m

$ ./out/minikube addons open heapster
Opening kubernetes service kube-system/monitoring-grafana in default browser...

A preview:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 10, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #2182 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2182      +/-   ##
=========================================
- Coverage   28.64%   28.6%   -0.04%     
=========================================
  Files          82      82              
  Lines        5369    5369              
=========================================
- Hits         1538    1536       -2     
- Misses       3636    3637       +1     
- Partials      195     196       +1
Impacted Files Coverage Δ
pkg/util/kubeconfig/config.go 47.61% <0%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65d11b1...7066946. Read the comment docs.

@r2d4
Copy link
Contributor

r2d4 commented Nov 10, 2017

@minikube-bot test this please

@kairen
Copy link
Contributor Author

kairen commented Nov 14, 2017

Hi @r2d4 This looks very close to being ready to go?

Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r2d4 r2d4 merged commit 43d8424 into kubernetes:master Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants