Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly use localkube bootstrapper and binary #2101

Merged
merged 3 commits into from
Oct 31, 2017

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Oct 20, 2017

Use the localkube binary built from CI in the integration tests.

Needed since #2089

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 20, 2017
@codecov-io
Copy link

codecov-io commented Oct 20, 2017

Codecov Report

Merging #2101 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2101      +/-   ##
==========================================
+ Coverage   28.76%   28.76%   +<.01%     
==========================================
  Files          81       81              
  Lines        5322     5325       +3     
==========================================
+ Hits         1531     1532       +1     
- Misses       3598     3599       +1     
- Partials      193      194       +1
Impacted Files Coverage Δ
...inikube/kubernetes_versions/kubernetes_versions.go 65.3% <0%> (-4.26%) ⬇️
pkg/util/kubeconfig/config.go 47.61% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0175adf...3fceab3. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2017
@r2d4 r2d4 force-pushed the use-ci-localkube branch 6 times, most recently from cfd55ba to 6952c5c Compare October 30, 2017 22:42
@r2d4 r2d4 merged commit e68de40 into kubernetes:master Oct 31, 2017
@r2d4 r2d4 deleted the use-ci-localkube branch October 31, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants