Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rootless: support --container-runtime=docker #17520

Merged
merged 1 commit into from
Oct 31, 2023
Merged

rootless: support --container-runtime=docker #17520

merged 1 commit into from
Oct 31, 2023

Conversation

AkihiroSuda
Copy link
Member

This allows running Kubernetes with (CRI-)Dockerd in Rootless Docker:

minikube start --rootless --driver=docker --container-runtime=docker

It is still recommended to use --container-runtime=containerd.

fixes #17322

@AkihiroSuda
rootless: support --container-runtime=docker
4c2180a 
This allows running Kubernetes with (CRI-)Dockerd in Rootless Docker:
```
minikube start --rootless --driver=docker --container-runtime=docker
```

It is still recommended to use `--container-runtime=containerd`.

Fix issue 17322

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 29, 2023
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AkihiroSuda
Once this PR has been reviewed and has the lgtm label, please assign spowelljr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AkihiroSuda AkihiroSuda mentioned this pull request Oct 29, 2023
Closed
@medyagh
Copy link
Member

medyagh commented Oct 30, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 30, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17520) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 51.4s               |
| enable ingress | 26.9s    | 26.2s               |
+----------------+----------+---------------------+

Times for minikube start: 48.4s 50.9s 51.5s 51.3s 52.2s
Times for minikube (PR 17520) start: 51.6s 50.5s 52.4s 51.1s 51.7s

Times for minikube (PR 17520) ingress: 27.2s 25.2s 24.3s 27.7s 26.7s
Times for minikube ingress: 28.1s 24.2s 27.1s 27.6s 27.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17520) |
+----------------+----------+---------------------+
| minikube start | 24.3s    | 24.9s               |
| enable ingress | 20.1s    | 20.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 17520) start: 25.0s 24.7s 24.9s 25.7s 24.5s
Times for minikube start: 24.1s 25.2s 21.9s 25.5s 24.7s

Times for minikube ingress: 18.8s 20.8s 20.8s 19.3s 20.8s
Times for minikube (PR 17520) ingress: 19.8s 20.8s 19.8s 20.8s 20.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17520) |
+----------------+----------+---------------------+
| minikube start | 23.8s    | 22.2s               |
| enable ingress | 31.1s    | 34.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 30.3s 31.3s 31.3s 31.3s 31.3s
Times for minikube (PR 17520) ingress: 47.4s 30.3s 31.3s 30.3s 31.4s

Times for minikube start: 23.7s 24.3s 23.6s 23.5s 23.9s
Times for minikube (PR 17520) start: 20.1s 20.3s 23.7s 23.0s 23.8s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestFunctional/parallel/CertSync (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/CpCmd (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/FileSync (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/MySQL (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/NodeLabels (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmdConnect (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/SSHCmd (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/StatusCmd (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 0.00 (chart)
Hyperkit_macOS TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh) 0.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 4852641 into kubernetes:master Oct 31, 2023
32 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prezha prezha Awaiting requested review from prezha

@spowelljr spowelljr Awaiting requested review from spowelljr

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rootless: support --container-runtime=docker
5 participants
@AkihiroSuda @minikube-bot @k8s-ci-robot @medyagh @minikube-pr-bot