audit log: set default max size

[spowelljr]

I was looking at some of our CI machines and the audit logging was failing:

E0519 17:42:33.138427  334137 logFile.go:53] failed to close the audit log: invalid argument

Then I looked at the size of the file:

-rw-r--r-- 1 perf perf 651M May 19 17:44 /home/perf/.minikube/logs/audit.json

It has over 1.6 million lines of audits:

1621891 /home/perf/.minikube/logs/audit.json

This PR sets the default number of audit lines to 1000 if not explicitly set by the user.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

hm... I wonder what is the best thing to do to if the audilog was already more than that in the files...should delete it ?

[spowelljr]

This will truncate the existing file, so if it's currently 2000 lines, it will truncate it to the last 1000

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16543) |
+----------------+----------+---------------------+
| minikube start | 53.4s    | 52.9s               |
| enable ingress | 28.2s    | 28.1s               |
+----------------+----------+---------------------+

Times for minikube start: 51.9s 53.2s 53.0s 54.3s 54.6s
Times for minikube (PR 16543) start: 51.8s 55.2s 51.1s 52.3s 54.1s

Times for minikube ingress: 27.7s 28.2s 28.2s 28.6s 28.2s
Times for minikube (PR 16543) ingress: 27.7s 28.2s 28.1s 28.6s 28.1s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 16543) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 23.4s               |
| enable ingress | 20.6s    | 21.0s               |
+----------------+----------+---------------------+

Times for minikube start: 21.5s 23.9s 21.2s 24.5s 21.5s
Times for minikube (PR 16543) start: 21.6s 21.7s 24.0s 25.3s 24.6s

Times for minikube ingress: 20.8s 20.8s 20.8s 20.8s 19.9s
Times for minikube (PR 16543) ingress: 21.3s 20.8s 21.3s 20.8s 20.8s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 16543) |
+-------------------+----------+---------------------+
| minikube start    | 22.3s    | 21.8s               |
| ⚠️  enable ingress | 26.1s    | 31.4s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube (PR 16543) start: 20.8s 23.3s 20.6s 21.1s 23.2s
Times for minikube start: 22.9s 21.2s 22.9s 20.4s 24.2s

Times for minikube ingress: 31.3s 30.3s 19.3s 18.4s 31.3s
Times for minikube (PR 16543) ingress: 31.3s 30.4s 31.4s 30.3s 33.4s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Hyperkit_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	5.77 (chart)
QEMU_macOS	TestImageBuild/serial/BuildWithBuildArg (gopogh)	27.52 (chart)

To see the flake rates of all tests by environment, click here.