added detail json for addons

[swastik959]

added detail json for addons

• fixes implement "detailed" addon list for -o=json #15862
  before
  

After

[k8s-ci-robot]

Hi @swastik959. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

Thank u for this contribution can u please put the output of minikube before/after this pr

[swastik959]

Thank u for this contribution can u please put the output of minikube before/after this pr

@medyagh attached the screenshots . are these the changes you wanted

[spowelljr]

This implementation of the PR doesn't respect the -d flag. The extra fields should only be shown if -d is passed, but currently it's always outputting the extra fields.

[swastik959]

@spowelljr although I have fixed it now but somehow first docs are printing

[spowelljr]

@spowelljr although I have fixed it now but somehow first docs are printing

I'm not sure what you mean by this, could you explain

[swastik959]

@spowelljr see the attached image in the release notes in the after section

[spowelljr]

@spowelljr see the attached image in the release notes in the after section

Maps in go are unordered so you can't guarantee the order. But it doesn't matter as this is JSON and only computers are going to use it and they also don't care about the order.

[spowelljr]

Also, please run make test before pushing changes up to ensure they pass linting and unit tests.

[swastik959]

@spowelljr how do I fix linting and unit-tests

[spowelljr]

To fix the linting run gofmt -s -w . the unit test is failing because you're using custom indenting with json.MarshalIndent so you either have to remove it or update the test.

[swastik959]

@spowelljr please review this pr now

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15866) |
+----------------+----------+---------------------+
| minikube start | 55.4s    | 56.4s               |
| enable ingress | 27.5s    | 27.3s               |
+----------------+----------+---------------------+

Times for minikube start: 55.9s 55.7s 56.2s 53.9s 55.3s
Times for minikube (PR 15866) start: 58.3s 56.5s 54.9s 54.4s 57.7s

Times for minikube ingress: 29.3s 28.8s 25.3s 25.2s 28.8s
Times for minikube (PR 15866) ingress: 28.8s 28.2s 25.2s 29.3s 24.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15866) |
+----------------+----------+---------------------+
| minikube start | 27.1s    | 26.6s               |
| enable ingress | 21.2s    | 21.6s               |
+----------------+----------+---------------------+

Times for minikube (PR 15866) start: 26.2s 27.2s 25.6s 26.5s 27.5s
Times for minikube start: 26.9s 27.5s 27.8s 26.4s 26.7s

Times for minikube (PR 15866) ingress: 20.6s 21.1s 23.1s 21.1s 22.1s
Times for minikube ingress: 22.1s 21.1s 22.1s 20.6s 20.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15866) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 22.6s               |
| enable ingress | 41.8s    | 27.2s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 22.4s 22.0s 22.4s 22.3s
Times for minikube (PR 15866) start: 22.4s 22.5s 22.7s 22.6s 22.8s

Times for minikube ingress: 32.6s 31.6s 32.6s 79.6s 32.6s
Times for minikube (PR 15866) ingress: 31.6s 21.6s 19.6s 30.6s 32.6s

[minikube-pr-bot]

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Cloud_Shell	TestFunctional/parallel/MountCmd/specific-port (gopogh)	0.00 (chart)
Docker_Windows	TestRunningBinaryUpgrade (gopogh)	0.00 (chart)
Hyperkit_macOS	TestNoKubernetes/serial/Start (gopogh)	0.00 (chart)
Hyperkit_macOS	TestNetworkPlugins/group/bridge/Start (gopogh)	0.66 (chart)
Hyperkit_macOS	TestNoKubernetes/serial/StartWithStopK8s (gopogh)	0.66 (chart)
Docker_Linux	TestMultiNode/serial/DeployApp2Nodes (gopogh)	39.18 (chart)
Docker_Linux	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	39.18 (chart)
Docker_macOS	TestMultiNode/serial/DeployApp2Nodes (gopogh)	39.88 (chart)
Docker_macOS	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	39.88 (chart)
Hyper-V_Windows	TestPause/serial/SecondStartNoReconfiguration (gopogh)	64.00 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	80.00 (chart)
Hyper-V_Windows	TestRunningBinaryUpgrade (gopogh)	96.00 (chart)
Hyper-V_Windows	TestStoppedBinaryUpgrade/Upgrade (gopogh)	96.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh)	99.39 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh)	100.00 (chart)
Docker_macOS	TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh)	100.00 (chart)
Docker_macOS	TestKubernetesUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestMissingContainerUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestRunningBinaryUpgrade (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh)	100.00 (chart)
Docker_macOS	TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh)	100.00 (chart)
Docker_macOS	TestStoppedBinaryUpgrade/Upgrade (gopogh)	100.00 (chart)
Docker_Windows	TestFunctional/parallel/ServiceCmd (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartKeepsNodes (gopogh)	100.00 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, swastik959

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment