Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kicbase: Update Ubuntu base image to focal-20230126 #15768

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Kicbase: Update Ubuntu base image to focal-20230126 #15768

merged 2 commits into from
Feb 16, 2023

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Feb 1, 2023 •
edited
Loading

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 1, 2023
@spowelljr spowelljr changed the title Kicbase: Updated Ubuntu base image Kicbase: Update Ubuntu base image Feb 1, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2023
@spowelljr spowelljr marked this pull request as ready for review February 16, 2023 00:07
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2023
@spowelljr
Copy link
Member Author

ok-to-build-image

@spowelljr spowelljr mentioned this pull request Feb 16, 2023
Closed
@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 16, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15768) |
+----------------+----------+---------------------+
| minikube start | 55.5s    | 55.3s               |
| enable ingress | 29.0s    | 27.8s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.8s 27.8s 31.3s 29.8s 28.3s
Times for minikube (PR 15768) ingress: 26.3s 26.2s 28.9s 28.8s 28.8s

Times for minikube start: 55.9s 54.8s 57.0s 54.9s 55.1s
Times for minikube (PR 15768) start: 54.1s 55.6s 57.2s 56.4s 53.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15768) |
+----------------+----------+---------------------+
| minikube start | 27.8s    | 28.0s               |
| enable ingress | 34.2s    | 21.5s               |
+----------------+----------+---------------------+

Times for minikube start: 27.6s 27.9s 27.8s 28.0s 27.6s
Times for minikube (PR 15768) start: 28.4s 26.8s 28.1s 27.7s 29.1s

Times for minikube ingress: 22.1s 23.2s 22.2s 81.6s 22.1s
Times for minikube (PR 15768) ingress: 22.1s 20.2s 22.1s 22.1s 21.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15768) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 23.1s               |
| enable ingress | 30.0s    | 25.9s               |
+----------------+----------+---------------------+

Times for minikube start: 22.1s 22.4s 23.1s 22.7s 22.7s
Times for minikube (PR 15768) start: 23.2s 22.8s 23.2s 22.7s 23.5s

Times for minikube ingress: 33.6s 32.6s 31.6s 19.6s 32.6s
Times for minikube (PR 15768) ingress: 19.7s 23.6s 20.6s 32.7s 32.7s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestRunningBinaryUpgrade (gopogh) 0.00 (chart)
Hyperkit_macOS TestStartStop/group/newest-cni/serial/Pause (gopogh) 1.41 (chart)
Hyperkit_macOS TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 1.41 (chart)
Hyperkit_macOS TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh) 1.41 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 3.64 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 3.64 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 5.10 (chart)
Docker_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 5.10 (chart)
KVM_Linux_containerd TestJSONOutput/stop/parallel/DistinctCurrentSteps (gopogh) 9.15 (chart)
KVM_Linux_containerd TestJSONOutput/stop/parallel/IncreasingCurrentSteps (gopogh) 9.15 (chart)
Hyper-V_Windows TestNoKubernetes/serial/StartWithK8s (gopogh) 95.71 (chart)
Hyper-V_Windows TestRunningBinaryUpgrade (gopogh) 98.57 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 98.73 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
Docker_Windows TestFunctional/parallel/ServiceCmd (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Hyper-V_Windows TestMultiNode/serial/RestartKeepsNodes (gopogh) 100.00 (chart)
Hyper-V_Windows TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 3719f06 into kubernetes:master Feb 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr, YasinAshorian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh changed the title Kicbase: Update Ubuntu base image Kicbase: Update Ubuntu base image to focal-20230126 Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@YasinAshorian YasinAshorian YasinAshorian approved these changes

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spowelljr @k8s-ci-robot @minikube-bot @minikube-pr-bot @medyagh @YasinAshorian