feat: direct image build on containerd via docker-env #15452

ComradeProgrammer · 2022-12-02T12:42:08Z

fixes #15389
This pr enable the use of minikube docker-env command, so that the minikube can be used as docker, even when the runtime is containerd

Before:

$ minikube start  --container-runtime="containerd"
$ minikube ssh-host --append-known
$ minikube docker-env --ssh-host --ssh-add
❌  Exiting due to MK_USAGE: The docker-env command is only compatible with the "docker" runtime, but this cluster was configured to use the "containerd" runtime.

After:

$ minikube docker-env --ssh-host --ssh-add
stdout:

export DOCKER_HOST="ssh://docker@127.0.0.1:49157"
export MINIKUBE_ACTIVE_DOCKERD="minikube"
export SSH_AUTH_SOCK="/tmp/ssh-XXXXXXqYJ2oD/agent.4680"
export SSH_AGENT_PID="4681"

stderr:

❗  Using the docker-env command with the containerd runtime is a highly experimental feature, please provide feedback or contribute to make it better
❗  Please ensure you have executed 'ssh-agent bash' and 'minikube ssh-host --append-known' in this shell before using docker-env on containerd. Ignore this message if you have done it

# To point your shell to minikube's docker-daemon, run:
# eval $(minikube -p minikube docker-env --ssh-host)
Identity added: /home/tjm/.minikube/machines/minikube/id_rsa (/home/tjm/.minikube/machines/minikube/id_rsa)

$ DOCKER_HOST="ssh://docker@127.0.0.1:49157" docker version


Client: Docker Engine - Community
 Version:           20.10.21
 API version:       1.40
 Go version:        go1.18.7
 Git commit:        baeda1f
 Built:             Tue Oct 25 18:01:58 2022
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

Server:
 nerdctl:
  Version:          1.0.0
 buildctl:
  Version:          0.10.3
  GitCommit:        c8d25d9a103b70dc300a4fd55e7e576472284e31
 containerd:
  Version:          1.6.10
  GitCommit:        770bd0108c32f3fb5c73ae1264f7e503fe7b2661
 runc:
  Version:          1.1.4
 Engine:
  Version:          1.0.0
  API version:      1.40 (minimum version 1.24)
  Go version:       go1.19.2
  Git commit:       c00780a1f5b905b09812722459c54936c9e070e6
  Built:            
  OS/Arch:          linux/amd64
  Experimental:     true

Note: when you execute docker ps, and see this output

error during connect: Get "http://docker.example.com/v1.24/containers/json": command [ssh -l docker -p 49172 -- 127.0.0.1 docker system dial-stdio] has exited with exit status 255, please make sure the URL is valid, and Docker 18.09 or later is installed on the remote host: stderr=@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@    WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!     @
@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
IT IS POSSIBLE THAT SOMEONE IS DOING SOMETHING NASTY!
Someone could be eavesdropping on you right now (man-in-the-middle attack)!
It is also possible that a host key has just been changed.
The fingerprint for the ED25519 key sent by the remote host is
SHA256:f3YSkwnLLvAPSJf0ZpSNGW+4u/iBOek/y+Kkb73PZ8g.
Please contact your system administrator.
Add correct host key in /home/tjm/.ssh/known_hosts to get rid of this message.
Offending RSA key in /home/tjm/.ssh/known_hosts:11
  remove with:
  ssh-keygen -f "/home/tjm/.ssh/known_hosts" -R "[127.0.0.1]:49172"
Host key for [127.0.0.1]:49172 has changed and you have requested strict checking.
Host key verification failed.

Then just copy the ssh-keygen command in the output and execute it.
then execute minikube ssh-host --append-known minikube docker-env --ssh-host --ssh-add again.
It will work

k8s-ci-robot · 2022-12-02T12:42:17Z

Hi @ComradeProgrammer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2022-12-02T12:48:04Z

Can one of the admins verify this patch?

medyagh

thank you for this PR, do you mind adding in the PR description an example of using it ? with the output

afbjorklund

I was imagining the nerdctl support to be much more similar to the podman support

pkg/minikube/download/download.go

pkg/minikube/download/docker_env.go

cmd/minikube/cmd/docker-env.go

ComradeProgrammer · 2022-12-10T09:15:18Z

By the way could you please give me a more specific hint about how podman is provisioned with the node ? I didn't find that. So I just moved the downloading procedure to the 'minikube start' phase, after the node is provisioned
@afbjorklund

afbjorklund · 2022-12-11T09:09:21Z

By the way could you please give me a more specific hint about how podman is provisioned with the node ?

https://github.com/kubernetes/minikube/blob/v1.28.0/deploy/kicbase/Dockerfile#L188

https://github.com/kubernetes/minikube/blob/v1.28.0/deploy/iso/minikube-iso/package/podman/podman.mk

Eventually it is supposed to be done by the provisioner (in libmachine), but that is not working at the moment.

So eventually, it would be nice if minikube knew how to install a container runtime on a node (a.k.a. provisioning)

But at the moment, users of the "none" driver (or the generic "ssh" driver) will just have to install it themselves.

Since the issues were written, the CRI and CNI components have moved to be included with Kubernetes:

Install cri-tools/cni-plugins with bootstrapper, and not with provisioner #15460

ComradeProgrammer · 2022-12-15T11:10:28Z

@afbjorklund Thanks for your guidance. Now nerdctld will be started when minikube starts, and now nerdctld listen on nerdctld instead of docker.sock. Is there any other suggestions? Or revisions I need to make?

medyagh · 2022-12-15T17:51:21Z

@afbjorklund Thanks for your guidance. Now nerdctld will be started when minikube starts, and now nerdctld listen on nerdctld instead of docker.sock. Is there any other suggestions? Or revisions I need to make?

can u plz update the PR description with the example output of using it?

ComradeProgrammer · 2022-12-16T16:21:12Z

@afbjorklund Thanks for your guidance. Now nerdctld will be started when minikube starts, and now nerdctld listen on nerdctld instead of docker.sock. Is there any other suggestions? Or revisions I need to make?

can u plz update the PR description with the example output of using it?

Of course, I will update it very soon.

medyagh

lets mark this as beta feature, and print to user that this might not be perfect.

medyagh

lets add a case for containerd in DockerEnv test inside functional tests. if it is containerd , it should run it with this new feature

ComradeProgrammer · 2022-12-26T09:53:46Z

lets add a case for containerd in DockerEnv test inside functional tests. if it is containerd , it should run it with this new feature

a test case has been added

ComradeProgrammer · 2023-01-17T11:50:51Z

Anything I need to do next?
@medyagh @spowelljr @afbjorklund

afbjorklund · 2023-01-17T14:08:52Z

Will take another look, if you feel that it is done.

cmd/minikube/cmd/docker-env.go

cmd/minikube/cmd/start.go

test/integration/docker_test.go

pkg/minikube/download/docker_env.go

cmd/minikube/cmd/start.go

test/integration/docker_test.go

pkg/minikube/download/docker_env.go

cmd/minikube/cmd/start.go

pkg/minikube/download/docker_env.go

test.txt

medyagh · 2023-02-27T19:46:26Z

/ok-to-test

minikube-pr-bot · 2023-07-01T20:16:06Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15452) |
+----------------+----------+---------------------+
| minikube start | 51.8s    | 50.5s               |
| enable ingress | 28.1s    | 28.4s               |
+----------------+----------+---------------------+

Times for minikube start: 51.5s 52.3s 52.4s 52.9s 49.8s
Times for minikube (PR 15452) start: 50.1s 51.7s 50.5s 50.2s 49.8s

Times for minikube ingress: 27.7s 29.3s 28.2s 27.3s 28.2s
Times for minikube (PR 15452) ingress: 28.3s 28.2s 28.7s 28.4s 28.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15452) |
+----------------+----------+---------------------+
| minikube start | 24.3s    | 23.5s               |
| enable ingress | 49.3s    | 49.4s               |
+----------------+----------+---------------------+

Times for minikube start: 25.4s 22.1s 24.8s 25.7s 23.4s
Times for minikube (PR 15452) start: 21.8s 25.4s 21.5s 25.7s 22.9s

Times for minikube ingress: 48.3s 48.4s 51.3s 49.9s 48.4s
Times for minikube (PR 15452) ingress: 48.8s 48.3s 48.4s 50.9s 50.4s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15452) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 22.8s               |
| enable ingress | 31.6s    | 34.8s               |
+----------------+----------+---------------------+

Times for minikube start: 23.6s 22.6s 21.2s 24.3s 21.0s
Times for minikube (PR 15452) start: 23.1s 20.4s 23.6s 23.8s 23.2s

Times for minikube ingress: 32.4s 31.4s 31.4s 31.3s 31.4s
Times for minikube (PR 15452) ingress: 31.3s 32.4s 47.4s 31.4s 31.4s

minikube-pr-bot · 2023-07-01T21:44:59Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh)	6.21 (chart)

To see the flake rates of all tests by environment, click here.

ComradeProgrammer · 2023-07-02T10:38:53Z

@medyagh @spowelljr

Now the PR has be rebased and modified, and now we no longer require the user to execute something like ssh-agent bash. Instead just one minikube docker-env --ssh-host --ssh-add, and everything will be done.

The new usage information has been updated in the PR's explanation.
The integration tests have passed.

Please have a look at it again if you have time. Thanks.

pkg/minikube/reason/reason.go

cmd/minikube/cmd/docker-env.go

test/integration/docker_test.go

cmd/minikube/cmd/docker-env.go

minikube-pr-bot · 2023-07-06T18:06:41Z

kvm2 driver with docker runtime
error collecting results for kvm2 driver: timing run 2 with minikube (PR 15452): timing cmd: [/home/jenkins/.minikube/minikube-binaries/15452/minikube start --driver=kvm2 --container-runtime=docker]: waiting for minikube: exit status 90
docker driver with docker runtime
error downloading artifacts: artifact download start: exit status 81docker driver with containerd runtime
error downloading artifacts: artifact download start: exit status 81

minikube-pr-bot · 2023-07-06T20:50:07Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
KVM_Linux_containerd	TestFunctional/parallel/DashboardCmd (gopogh)	0.59 (chart)
KVM_Linux_crio	TestFunctional/parallel/DashboardCmd (gopogh)	0.60 (chart)
Docker_Linux_docker_arm64	TestFunctional/parallel/MountCmd/specific-port (gopogh)	1.18 (chart)
Hyperkit_macOS	TestForceSystemdEnv (gopogh)	1.82 (chart)
QEMU_macOS	TestJSONOutput/pause/Command (gopogh)	6.88 (chart)
QEMU_macOS	TestJSONOutput/start/Command (gopogh)	6.88 (chart)
QEMU_macOS	TestJSONOutput/unpause/Command (gopogh)	6.88 (chart)
KVM_Linux_crio	TestFunctional/serial/LogsFileCmd (gopogh)	8.93 (chart)

To see the flake rates of all tests by environment, click here.

spowelljr · 2023-07-10T23:26:52Z

ok-to-build-image

cmd/minikube/cmd/docker-env.go

minikube-bot · 2023-07-10T23:52:26Z

Hi @ComradeProgrammer, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

minikube-pr-bot · 2023-07-11T00:30:19Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15452) |
+----------------+----------+---------------------+
| minikube start | 51.5s    | 51.9s               |
| enable ingress | 28.5s    | 27.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 28.2s 28.2s 28.2s 28.2s 29.7s
Times for minikube (PR 15452) ingress: 27.2s 27.2s 28.7s 25.3s 29.2s

Times for minikube start: 50.5s 52.5s 51.9s 51.1s 51.7s
Times for minikube (PR 15452) start: 51.9s 52.0s 49.7s 52.7s 53.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15452) |
+----------------+----------+---------------------+
| minikube start | 23.7s    | 23.9s               |
| enable ingress | 48.7s    | 48.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 48.8s 49.3s 48.3s 48.9s 48.3s
Times for minikube (PR 15452) ingress: 48.8s 48.3s 48.3s 48.8s 49.3s

Times for minikube start: 21.7s 24.3s 25.4s 24.7s 22.3s
Times for minikube (PR 15452) start: 22.2s 25.1s 24.9s 24.9s 22.2s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15452) |
+----------------+----------+---------------------+
| minikube start | 22.9s    | 21.8s               |
| enable ingress | 31.0s    | 26.2s               |
+----------------+----------+---------------------+

Times for minikube start: 24.6s 23.4s 20.3s 23.8s 22.7s
Times for minikube (PR 15452) start: 21.1s 23.4s 23.1s 20.9s 20.4s

Times for minikube ingress: 31.4s 30.3s 31.4s 30.3s 31.4s
Times for minikube (PR 15452) ingress: 30.3s 31.5s 19.4s 18.4s 31.4s

minikube-pr-bot · 2023-07-11T00:58:34Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15452) |
+----------------+----------+---------------------+
| minikube start | 50.9s    | 52.1s               |
| enable ingress | 27.2s    | 27.9s               |
+----------------+----------+---------------------+

Times for minikube start: 51.1s 48.2s 50.3s 52.5s 52.3s
Times for minikube (PR 15452) start: 50.2s 50.5s 50.6s 56.6s 52.8s

Times for minikube ingress: 27.2s 28.2s 27.2s 26.8s 26.7s
Times for minikube (PR 15452) ingress: 29.2s 27.2s 28.2s 27.8s 27.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15452) |
+----------------+----------+---------------------+
| minikube start | 23.3s    | 23.7s               |
| enable ingress | 49.4s    | 37.6s               |
+----------------+----------+---------------------+

Times for minikube start: 24.4s 22.5s 24.7s 21.8s 23.1s
Times for minikube (PR 15452) start: 26.1s 25.5s 22.7s 22.2s 22.0s

Times for minikube (PR 15452) ingress: 48.9s 27.9s 32.9s 28.9s 49.4s
Times for minikube ingress: 49.4s 49.4s 49.3s 49.4s 49.4s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15452) |
+-------------------+----------+---------------------+
| minikube start    | 22.4s    | 21.5s               |
| ⚠️  enable ingress | 29.2s    | 34.8s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube ingress: 31.4s 31.4s 19.4s 32.4s 31.3s
Times for minikube (PR 15452) ingress: 31.4s 32.4s 31.4s 47.4s 31.4s

Times for minikube start: 24.3s 23.2s 20.9s 20.8s 23.0s
Times for minikube (PR 15452) start: 20.4s 21.0s 21.2s 24.0s 21.1s

minikube-pr-bot · 2023-07-11T01:43:06Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestDockerEnvContainerd (gopogh)	n/a
QEMU_macOS	TestFunctional/parallel/CertSync (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/DockerEnv/bash (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/FileSync (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageBuild (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/NodeLabels (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/DeployApp (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/Format (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/HTTPS (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/List (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/URL (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/StatusCmd (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/TunnelCmd/serial/DNSResolutionByDig (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/parallel/Version/components (gopogh)	1.33 (chart)
QEMU_macOS	TestFunctional/serial/ComponentHealth (gopogh)	1.33 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2023-07-11T03:10:42Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestDockerEnvContainerd (gopogh)	n/a
QEMU_macOS	TestFunctional/parallel/CertSync (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/DashboardCmd (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/DockerEnv/bash (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/FileSync (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageBuild (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/NodeLabels (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/DeployApp (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/Format (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/HTTPS (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/List (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/ServiceCmd/URL (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/StatusCmd (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/TunnelCmd/serial/DNSResolutionByDig (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/TunnelCmd/serial/WaitService/Setup (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/parallel/Version/components (gopogh)	1.32 (chart)
QEMU_macOS	TestFunctional/serial/ComponentHealth (gopogh)	1.32 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

medyagh

thank you for delivering this great feature @ComradeProgrammer and also thank you @spowelljr for the SSH agent that was required for this PR and follow up fixes

k8s-ci-robot · 2023-07-11T20:42:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2022

k8s-ci-robot requested review from medyagh and sharifelgamal December 2, 2022 12:42

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 2, 2022

medyagh reviewed Dec 2, 2022

View reviewed changes

afbjorklund requested changes Dec 3, 2022

View reviewed changes

ComradeProgrammer force-pushed the docker-env branch from d53ebd2 to 0c67a19 Compare December 10, 2022 08:30

ComradeProgrammer force-pushed the docker-env branch from 0c67a19 to 70c396d Compare December 15, 2022 11:06

medyagh requested changes Dec 19, 2022

View reviewed changes

medyagh reviewed Dec 19, 2022

View reviewed changes

ComradeProgrammer force-pushed the docker-env branch from 70c396d to 815007c Compare December 26, 2022 09:53

spowelljr requested changes Jan 30, 2023

View reviewed changes

ComradeProgrammer force-pushed the docker-env branch from 815007c to cf9cfed Compare February 5, 2023 14:11

spowelljr requested changes Feb 6, 2023

View reviewed changes

ComradeProgrammer force-pushed the docker-env branch 2 times, most recently from 3ded273 to 3a1686e Compare February 10, 2023 06:19

medyagh requested changes Feb 27, 2023

View reviewed changes

test.txt Outdated Show resolved Hide resolved

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 27, 2023

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2023

spowelljr requested changes Jul 5, 2023

View reviewed changes

ComradeProgrammer force-pushed the docker-env branch from ae624d9 to 2e4912e Compare July 6, 2023 16:31

feat: use automated ssh-agent in docker-env

a814542

ComradeProgrammer force-pushed the docker-env branch from 2e4912e to a814542 Compare July 6, 2023 16:35

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2023

Merge branch 'master' into docker-env

47b5190

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2023

spowelljr requested changes Jul 10, 2023

View reviewed changes

cmd/minikube/cmd/docker-env.go Outdated Show resolved Hide resolved

Updating kicbase image to v0.0.39-1689032083-15452

19e7ae6

medyagh approved these changes Jul 11, 2023

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023

fix lint error

d127660

spowelljr approved these changes Jul 11, 2023

View reviewed changes

spowelljr merged commit 46eebd4 into kubernetes:master Jul 11, 2023
9 checks passed

sethrylan mentioned this pull request Jul 21, 2023

docker-env errors if ~/.ssh doesn't exist #16933

Closed

spowelljr mentioned this pull request Aug 9, 2023

Fix calling appendKnownHelper when not needed #17030

Merged

ComradeProgrammer mentioned this pull request Aug 10, 2023

remove ssh-add flag and fix calling appendKnownHelper when not needed #17039

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: direct image build on containerd via docker-env #15452

feat: direct image build on containerd via docker-env #15452

ComradeProgrammer commented Dec 2, 2022 •

edited

Loading

k8s-ci-robot commented Dec 2, 2022

minikube-bot commented Dec 2, 2022

medyagh left a comment

afbjorklund left a comment

ComradeProgrammer commented Dec 10, 2022 •

edited

Loading

afbjorklund commented Dec 11, 2022

ComradeProgrammer commented Dec 15, 2022

medyagh commented Dec 15, 2022

ComradeProgrammer commented Dec 16, 2022

medyagh left a comment

medyagh left a comment

ComradeProgrammer commented Dec 26, 2022

ComradeProgrammer commented Jan 17, 2023

afbjorklund commented Jan 17, 2023

medyagh commented Feb 27, 2023

minikube-pr-bot commented Jul 1, 2023

minikube-pr-bot commented Jul 1, 2023

ComradeProgrammer commented Jul 2, 2023 •

edited

Loading

minikube-pr-bot commented Jul 6, 2023

minikube-pr-bot commented Jul 6, 2023

spowelljr commented Jul 10, 2023

minikube-bot commented Jul 10, 2023

minikube-pr-bot commented Jul 11, 2023

minikube-pr-bot commented Jul 11, 2023

minikube-pr-bot commented Jul 11, 2023

minikube-pr-bot commented Jul 11, 2023

medyagh left a comment

k8s-ci-robot commented Jul 11, 2023

feat: direct image build on containerd via docker-env #15452

feat: direct image build on containerd via docker-env #15452

Conversation

ComradeProgrammer commented Dec 2, 2022 • edited Loading

k8s-ci-robot commented Dec 2, 2022

minikube-bot commented Dec 2, 2022

medyagh left a comment

Choose a reason for hiding this comment

afbjorklund left a comment

Choose a reason for hiding this comment

ComradeProgrammer commented Dec 10, 2022 • edited Loading

afbjorklund commented Dec 11, 2022

ComradeProgrammer commented Dec 15, 2022

medyagh commented Dec 15, 2022

ComradeProgrammer commented Dec 16, 2022

medyagh left a comment

Choose a reason for hiding this comment

medyagh left a comment

Choose a reason for hiding this comment

ComradeProgrammer commented Dec 26, 2022

ComradeProgrammer commented Jan 17, 2023

afbjorklund commented Jan 17, 2023

medyagh commented Feb 27, 2023

minikube-pr-bot commented Jul 1, 2023

minikube-pr-bot commented Jul 1, 2023

ComradeProgrammer commented Jul 2, 2023 • edited Loading

minikube-pr-bot commented Jul 6, 2023

minikube-pr-bot commented Jul 6, 2023

spowelljr commented Jul 10, 2023

minikube-bot commented Jul 10, 2023

minikube-pr-bot commented Jul 11, 2023

minikube-pr-bot commented Jul 11, 2023

minikube-pr-bot commented Jul 11, 2023

minikube-pr-bot commented Jul 11, 2023

medyagh left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 11, 2023

ComradeProgrammer commented Dec 2, 2022 •

edited

Loading

ComradeProgrammer commented Dec 10, 2022 •

edited

Loading

ComradeProgrammer commented Jul 2, 2023 •

edited

Loading