Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade libvirt to "8th gen" #13440

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

prezha
Copy link
Contributor

@prezha prezha commented Jan 23, 2022

fixes: #9642

we've already upgraded from libvirt v3.9.0 to v7.4.0 (#13042)

recently, with v8, libvirt changed from github.com/libvirt/libvirt-go to libvirt.org/go/libvirt and this pr reflects that, which should, in turn, also ease future upgrades as well

my (light) local tests have shown no issues so far...

useful ref: libvirt API support matrix

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2022
@prezha prezha changed the title upgrade-libvirt to "8th gen" upgrade libvirt to "8th gen" Jan 23, 2022
@prezha
Copy link
Contributor Author

prezha commented Jan 23, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 23, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13440) |
+----------------+----------+---------------------+
| minikube start | 45.5s    | 43.8s               |
| enable ingress | 28.6s    | 28.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 29.1s 29.0s 30.0s 25.6s 29.6s
Times for minikube (PR 13440) ingress: 29.5s 29.6s 25.6s 29.1s 29.5s

Times for minikube start: 51.8s 43.8s 44.6s 43.8s 43.4s
Times for minikube (PR 13440) start: 45.1s 43.1s 43.2s 44.1s 43.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13440) |
+----------------+----------+---------------------+
| minikube start | 29.1s    | 25.9s               |
| enable ingress | 22.9s    | 22.4s               |
+----------------+----------+---------------------+

Times for minikube start: 42.0s 25.5s 25.6s 25.9s 26.3s
Times for minikube (PR 13440) start: 25.5s 26.5s 26.4s 25.6s 25.5s

Times for minikube ingress: 22.9s 21.9s 23.4s 22.9s 23.4s
Times for minikube (PR 13440) ingress: 22.4s 21.9s 22.4s 22.4s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13440) |
+----------------+----------+---------------------+
| minikube start | 42.5s    | 44.4s               |
| enable ingress | 22.5s    | 20.1s               |
+----------------+----------+---------------------+

Times for minikube (PR 13440) start: 44.6s 46.0s 41.9s 44.7s 45.0s
Times for minikube start: 43.9s 41.3s 45.7s 41.0s 40.6s

Times for minikube ingress: 22.9s 23.4s 19.4s 23.4s 23.4s
Times for minikube (PR 13440) ingress: 19.9s 18.9s 23.4s 18.9s 19.4s

@medyagh
Copy link
Member

medyagh commented Jan 25, 2022

I wonder if this test failure is related to this PR or not

for

https://storage.googleapis.com/minikube-builds/logs/13440/22345/KVM_Linux.html#fail_TestRunningBinaryUpgrade

	
	! 'kvm2' driver reported an issue: /usr/bin/virsh domcapabilities --virttype kvm failed:
	error: failed to get emulator capabilities
	error: invalid argument: KVM is not supported by '/usr/bin/qemu-system-x86_64' on this host
	* Suggestion: Follow your Linux distribution instructions for configuring KVM
	* Documentation: https://minikube.sigs.k8s.io/docs/reference/drivers/kvm2/

@medyagh medyagh merged commit 572e29e into kubernetes:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade libvirt
4 participants