Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ipv4 cidr in cilium #12587

Merged
merged 2 commits into from
Oct 15, 2021
Merged

Fix Ipv4 cidr in cilium #12587

merged 2 commits into from
Oct 15, 2021

Conversation

duttaANI
Copy link
Contributor

Description
fixes #12077

issue link : issue

@k8s-ci-robot
Copy link
Contributor

Welcome @duttaANI!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 27, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @duttaANI. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 27, 2021
@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2021
@@ -175,7 +175,7 @@ data:
hubble-tls-key-file: /var/lib/cilium/tls/hubble/server.key
hubble-tls-client-ca-files: /var/lib/cilium/tls/hubble/client-ca.crt
ipam: "cluster-pool"
cluster-pool-ipv4-cidr: "10.0.0.0/8"
cluster-pool-ipv4-cidr: "10.244.0.0/16"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this
we should make "tempaltized" for example

"{{ .PodSubnet }}"

so if user passes extra args we should use that simmilar to here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the template for extra args .

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 1, 2021
@duttaANI duttaANI requested a review from medyagh October 1, 2021 05:27
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12587) |
+----------------+----------+---------------------+
| minikube start | 48.9s    | 48.0s               |
| enable ingress | 32.8s    | 34.3s               |
+----------------+----------+---------------------+

Times for minikube start: 49.3s 48.9s 48.2s 49.1s 48.8s
Times for minikube (PR 12587) start: 48.1s 48.4s 47.8s 47.6s 48.2s

Times for minikube ingress: 32.8s 32.8s 34.2s 31.8s 32.3s
Times for minikube (PR 12587) ingress: 33.3s 32.4s 40.8s 32.8s 32.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12587) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.7s               |
| enable ingress | 30.7s    | 30.1s               |
+----------------+----------+---------------------+

Times for minikube ingress: 26.9s 35.4s 27.9s 27.9s 35.4s
Times for minikube (PR 12587) ingress: 34.9s 27.9s 34.4s 26.9s 26.4s

Times for minikube start: 22.5s 21.2s 20.9s 22.9s 22.6s
Times for minikube (PR 12587) start: 22.3s 21.1s 21.6s 22.2s 21.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12587) |
+----------------+----------+---------------------+
| minikube start | 40.2s    | 43.4s               |
| enable ingress | 32.8s    | 33.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 38.4s 31.9s 27.4s 29.4s 36.9s
Times for minikube (PR 12587) ingress: 17.4s 31.5s 36.9s 18.0s 62.9s

Times for minikube start: 27.4s 42.3s 44.2s 43.7s 43.4s
Times for minikube (PR 12587) start: 43.2s 43.3s 42.9s 44.0s 43.4s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestCertExpiration (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/newest-cni/serial/SecondStart (gopogh) 0.00 (chart)
Docker_Linux TestStartStop/group/newest-cni/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
Docker_Linux TestPause/serial/SecondStartNoReconfiguration (gopogh) 0.76 (chart)
Docker_Linux TestPause/serial/Start (gopogh) 0.76 (chart)
Docker_Linux TestPause/serial/Unpause (gopogh) 0.76 (chart)
Docker_Linux_containerd TestStartStop/group/no-preload/serial/Pause (gopogh) 2.27 (chart)
Docker_Linux TestPause/serial/PauseAgain (gopogh) 3.82 (chart)
Docker_Linux TestPause/serial/Pause (gopogh) 5.34 (chart)
Docker_Linux TestPause/serial/VerifyStatus (gopogh) 5.34 (chart)
Docker_Linux TestStartStop/group/newest-cni/serial/Pause (gopogh) 6.11 (chart)
Docker_Windows TestCertExpiration (gopogh) 14.29 (chart)
Docker_Windows TestFunctional/parallel/DryRun (gopogh) 20.16 (chart)
Docker_Linux_containerd TestPause/serial/Pause (gopogh) 20.45 (chart)
Docker_Linux_containerd TestPause/serial/PauseAgain (gopogh) 20.45 (chart)
Docker_Linux_containerd TestPause/serial/VerifyStatus (gopogh) 20.45 (chart)
KVM_Linux_containerd TestPause/serial/SecondStartNoReconfiguration (gopogh) 21.05 (chart)
Docker_Windows TestNetworkPlugins/group/auto/Start (gopogh) 21.74 (chart)
Docker_Windows TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 25.30 (chart)
Docker_Windows TestNetworkPlugins/group/false/Start (gopogh) 28.70 (chart)
Docker_Windows TestFunctional/parallel/StatusCmd (gopogh) 36.29 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/Start (gopogh) 45.22 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/Start (gopogh) 59.13 (chart)
Docker_Windows TestPause/serial/DeletePaused (gopogh) 65.57 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 66.09 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 71.30 (chart)
Docker_Windows TestNetworkPlugins/group/cilium/Start (gopogh) 72.17 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 73.04 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 89.57 (chart)
Docker_Windows TestCertOptions (gopogh) 99.19 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@duttaANI
Copy link
Contributor Author

duttaANI commented Oct 5, 2021

/assign @medyagh

@sharifelgamal
Copy link
Collaborator

/ok-to-test

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12587) |
+----------------+----------+---------------------+
| minikube start | 47.7s    | 47.0s               |
| enable ingress | 31.0s    | 31.4s               |
+----------------+----------+---------------------+

Times for minikube start: 49.0s 47.6s 48.2s 46.5s 47.1s
Times for minikube (PR 12587) start: 47.2s 46.7s 47.4s 47.5s 46.2s

Times for minikube ingress: 32.3s 31.3s 31.2s 29.3s 30.8s
Times for minikube (PR 12587) ingress: 31.3s 32.2s 30.8s 31.7s 30.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12587) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.5s               |
| enable ingress | 27.2s    | 34.7s               |
+----------------+----------+---------------------+

Times for minikube start: 22.2s 21.1s 23.0s 21.1s 22.4s
Times for minikube (PR 12587) start: 21.2s 21.0s 22.2s 21.4s 21.6s

Times for minikube ingress: 27.5s 27.0s 27.0s 28.0s 26.4s
Times for minikube (PR 12587) ingress: 36.4s 34.4s 33.9s 34.9s 34.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12587) |
+----------------+----------+---------------------+
| minikube start | 40.7s    | 40.1s               |
| enable ingress | 31.3s    | 31.8s               |
+----------------+----------+---------------------+

Times for minikube start: 31.2s 41.8s 43.3s 43.2s 43.9s
Times for minikube (PR 12587) start: 26.2s 43.7s 43.4s 43.3s 44.0s

Times for minikube ingress: 29.5s 32.9s 28.5s 32.9s 32.9s
Times for minikube (PR 12587) ingress: 35.9s 32.9s 32.9s 28.9s 28.5s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 1.31 (chart)
Docker_Linux_containerd TestStartStop/group/newest-cni/serial/Pause (gopogh) 1.32 (chart)
KVM_Linux TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 2.61 (chart)
KVM_Linux TestStoppedBinaryUpgrade/Upgrade (gopogh) 2.61 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@sharifelgamal
Copy link
Collaborator

Thank you for your contribution!

@sharifelgamal sharifelgamal merged commit 029a9d1 into kubernetes:master Oct 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duttaANI, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cilium CNI does not use Minikube Default Pod CIDR
7 participants