Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable port for minikube mount #11979

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Add configurable port for minikube mount #11979

merged 4 commits into from
Jul 26, 2021

Conversation

andriyDev
Copy link
Contributor

fixes #11978.

Now users can specify what port to use for mounting (in addition to allowing random port assignment). Also, adds advice for timing out mounting to check firewall.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2021
@andriyDev
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 14, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 48.0s    | 48.0s               |
| enable ingress | 32.3s    | 35.4s               |
+----------------+----------+---------------------+

Times for minikube start: 49.6s 47.6s 47.9s 47.3s 47.5s
Times for minikube (PR 11979) start: 48.5s 48.1s 48.4s 47.2s 47.7s

Times for minikube ingress: 33.3s 31.7s 32.3s 31.8s 32.3s
Times for minikube (PR 11979) ingress: 32.3s 40.3s 32.3s 32.3s 39.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 22.1s    | 21.6s               |
| enable ingress | 35.4s    | 35.7s               |
+----------------+----------+---------------------+

Times for minikube start: 22.9s 22.6s 22.0s 21.9s 21.1s
Times for minikube (PR 11979) start: 22.0s 21.4s 21.3s 21.1s 22.0s

Times for minikube ingress: 36.0s 35.5s 36.5s 36.5s 32.5s
Times for minikube (PR 11979) ingress: 35.5s 36.5s 35.5s 35.5s 35.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 42.0s    | 43.8s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.1s 44.2s 43.1s 44.0s 47.6s
Times for minikube (PR 11979) start: 43.8s 44.9s 43.0s 43.9s 43.3s

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2021
@andriyDev
Copy link
Contributor Author

This PR is great to read each commit separately I'd say, hint hint

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 49.7s    | 49.8s               |
| enable ingress | 33.7s    | 33.3s               |
+----------------+----------+---------------------+

Times for minikube start: 49.9s 51.6s 48.3s 48.9s 50.0s
Times for minikube (PR 11979) start: 48.7s 51.7s 49.7s 50.4s 48.7s

Times for minikube ingress: 31.8s 41.3s 31.8s 31.9s 31.8s
Times for minikube (PR 11979) ingress: 31.8s 31.8s 32.9s 32.3s 37.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 22.9s    | 22.1s               |
| enable ingress | 27.4s    | 29.0s               |
+----------------+----------+---------------------+

Times for minikube start: 23.8s 21.8s 23.3s 22.4s 23.3s
Times for minikube (PR 11979) start: 21.6s 21.9s 22.5s 22.1s 22.4s

Times for minikube ingress: 27.0s 26.5s 27.5s 29.5s 26.5s
Times for minikube (PR 11979) ingress: 27.0s 34.0s 27.0s 30.5s 26.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 40.0s    | 44.0s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.1s 43.3s 37.0s 43.4s 44.1s
Times for minikube (PR 11979) start: 44.1s 43.6s 44.1s 45.0s 43.2s

medyagh
medyagh requested changes Jul 15, 2021
View reviewed changes
pkg/minikube/cluster/mount.go Outdated Show resolved Hide resolved
@andriyDev andriyDev requested a review from medyagh July 15, 2021 23:22
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 49.2s    | 47.4s               |
| enable ingress | 33.7s    | 35.6s               |
+----------------+----------+---------------------+

Times for minikube start: 53.8s 48.0s 49.0s 47.4s 48.0s
Times for minikube (PR 11979) start: 47.3s 46.8s 47.9s 49.2s 46.0s

Times for minikube ingress: 32.3s 31.8s 39.8s 32.7s 31.9s
Times for minikube (PR 11979) ingress: 40.7s 33.7s 32.2s 39.3s 32.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 21.6s               |
| enable ingress | 34.2s    | 34.4s               |
+----------------+----------+---------------------+

Times for minikube start: 21.1s 21.6s 22.4s 22.3s 22.3s
Times for minikube (PR 11979) start: 22.0s 20.8s 22.0s 21.3s 21.7s

Times for minikube ingress: 35.5s 37.0s 31.5s 30.0s 37.0s
Times for minikube (PR 11979) ingress: 35.5s 36.0s 28.5s 35.5s 36.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 42.3s    | 43.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 43.1s 43.8s 44.0s 43.9s 36.9s
Times for minikube (PR 11979) start: 43.8s 43.0s 43.9s 43.2s 44.1s

@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 48.9s    | 48.4s               |
| enable ingress | 31.9s    | 31.9s               |
+----------------+----------+---------------------+

Times for minikube start: 49.9s 48.4s 47.9s 49.2s 49.3s
Times for minikube (PR 11979) start: 49.4s 47.6s 47.9s 49.9s 47.1s

Times for minikube (PR 11979) ingress: 32.4s 31.3s 31.8s 32.3s 31.8s
Times for minikube ingress: 31.4s 32.8s 31.8s 31.9s 31.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 22.4s    | 22.0s               |
| enable ingress | 30.0s    | 29.0s               |
+----------------+----------+---------------------+

Times for minikube start: 23.5s 21.8s 21.8s 22.8s 21.8s
Times for minikube (PR 11979) start: 21.7s 22.4s 22.1s 21.8s 22.2s

Times for minikube ingress: 27.0s 34.5s 27.0s 34.5s 27.0s
Times for minikube (PR 11979) ingress: 30.0s 34.5s 26.5s 27.0s 27.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 40.2s    | 44.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 26.9s 44.5s 43.0s 43.2s 43.5s
Times for minikube (PR 11979) start: 43.2s 44.0s 48.0s 44.8s 43.3s

medyagh
medyagh requested changes Jul 21, 2021
View reviewed changes
cmd/minikube/cmd/mount.go Outdated Show resolved Hide resolved
@andriyDev andriyDev requested a review from medyagh July 22, 2021 17:40
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 47.8s    | 47.4s               |
| enable ingress | 33.7s    | 33.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.8s 32.2s 39.8s 32.3s 32.3s
Times for minikube (PR 11979) ingress: 31.3s 31.8s 31.8s 40.7s 31.8s

Times for minikube start: 48.2s 47.7s 48.5s 47.3s 47.1s
Times for minikube (PR 11979) start: 48.7s 47.3s 46.8s 47.0s 47.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 22.0s               |
| enable ingress | 34.0s    | 36.4s               |
+----------------+----------+---------------------+

Times for minikube start: 23.2s 21.7s 22.4s 22.1s 21.9s
Times for minikube (PR 11979) start: 21.5s 21.7s 22.5s 22.3s 22.1s

Times for minikube ingress: 31.5s 36.0s 35.5s 35.5s 31.5s
Times for minikube (PR 11979) ingress: 37.0s 36.0s 36.0s 37.5s 35.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11979) |
+----------------+----------+---------------------+
| minikube start | 39.6s    | 42.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.0s 43.0s 36.8s 43.3s 42.8s
Times for minikube (PR 11979) start: 46.1s 43.3s 43.5s 43.6s 37.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux_containerd) TestStoppedBinaryUpgrade/MinikubeLogs 0.00 (chart)
Docker_Linux) TestStartStop/group/newest-cni/serial/Pause 4.52 (chart)
Hyperkit_macOS) TestFunctional/parallel/DashboardCmd 12.04 (chart)
KVM_Linux_containerd) TestPause/serial/SecondStartNoReconfiguration 12.05 (chart)
KVM_Linux_crio) TestPause/serial/PauseAgain 12.42 (chart)
Docker_Windows) TestAddons/parallel/HelmTiller 13.54 (chart)
Docker_macOS) TestNetworkPlugins/group/bridge/Start 16.98 (chart)
Docker_macOS) TestNetworkPlugins/group/false/DNS 23.58 (chart)
Docker_macOS) TestNetworkPlugins/group/kubenet/Start 35.85 (chart)
Docker_Windows) TestStoppedBinaryUpgrade/MinikubeLogs 35.87 (chart)
Docker_Linux_crio_arm64) TestAddons/parallel/GCPAuth 36.54 (chart)
Docker_macOS) TestNetworkPlugins/group/calico/DNS 37.21 (chart)
Docker_Linux_crio_arm64) TestStartStop/group/no-preload/serial/UserAppExistsAfterStop 43.24 (chart)
Docker_macOS) TestNetworkPlugins/group/custom-weave/Start 43.40 (chart)
Docker_Linux_crio_arm64) TestAddons/parallel/CSI 44.23 (chart)
Docker_Windows) TestFunctional/parallel/StatusCmd 47.92 (chart)
Docker_Windows) TestNetworkPlugins/group/false/Start 50.00 (chart)
Docker_Linux_crio_arm64) TestFunctional/parallel/PersistentVolumeClaim 52.88 (chart)
Docker_Linux_crio_arm64) TestFunctional/parallel/TunnelCmd/serial/AccessDirect 52.88 (chart)
Docker_Linux_crio_arm64) TestMultiNode/serial/DeployApp2Nodes 54.81 (chart)
Docker_Linux_crio_arm64) TestMultiNode/serial/PingHostFrom2Pods 54.81 (chart)
Docker_macOS) TestNetworkPlugins/group/kindnet/Start 56.60 (chart)
Docker_Windows) TestPause/serial/VerifyStatus 58.33 (chart)
Docker_Windows) TestPause/serial/DeletePaused 59.76 (chart)
Docker_Windows) TestNetworkPlugins/group/enable-default-cni/Start 59.78 (chart)
Docker_macOS) TestNetworkPlugins/group/enable-default-cni/DNS 64.65 (chart)
Docker_Windows) TestNetworkPlugins/group/kindnet/Start 66.30 (chart)
Docker_Windows) TestNetworkPlugins/group/cilium/Start 67.39 (chart)
Docker_Windows) TestNetworkPlugins/group/bridge/Start 81.52 (chart)
Docker_Windows) TestNetworkPlugins/group/custom-weave/Start 83.87 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andriyDev, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2021
@medyagh medyagh merged commit c6ff620 into kubernetes:master Jul 26, 2021
@andriyDev andriyDev deleted the MountPort branch August 5, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add configurable port for minikube mount
4 participants
@andriyDev @minikube-pr-bot @k8s-ci-robot @medyagh