Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make sure path to logs directory exists #10806

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

prezha
Copy link
Contributor

@prezha prezha commented Mar 13, 2021

fixes #10804

the error description is in the issue, here is a small fix to make sure the path to the directory exists before calling os.OpenFile

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 13, 2021
@prezha prezha changed the title make sure directory exists make sure path to log directory exists Mar 13, 2021
@prezha prezha changed the title make sure path to log directory exists make sure path to logs directory exists Mar 13, 2021
pkg/minikube/audit/logFile.go Outdated Show resolved Hide resolved
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this PR would help users or would potnetially cause more problems (either adding tiny performance issues on slow disks) since it is gets called on each log run.

or maybe permission issues if 755 is not allowed by the admin. i think this only affects the integration tests. that could be fixed there?

@prezha
Copy link
Contributor Author

prezha commented Mar 18, 2021

I am not sure if this PR would help users or would potnetially cause more problems (either adding tiny performance issues on slow disks) since it is gets called on each log run.

or maybe permission issues if 755 is not allowed by the admin. i think this only affects the integration tests. that could be fixed there?

thank you for your review and comments @medyagh
i think that you are right - atm seems that only the tests are affected by this issue, so i moved the correction there

@prezha prezha requested a review from medyagh March 18, 2021 21:28
@medyagh medyagh merged commit ebb13e5 into kubernetes:master Mar 23, 2021
@medyagh medyagh changed the title make sure path to logs directory exists test: make sure path to logs directory exists Mar 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, prezha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestLogFile/SetLogFile fails: open ~/.minikube/logs/audit.json: no such file or directory
3 participants