iso: enable Network Block Device support #10217
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Welcome @pkalever! |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @pkalever. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
|
Can one of the admins verify this patch? |
For rbd-nbd testing purpose, this is needed. At least until we have minikube release with kubernetes/minikube#10217 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
For rbd-nbd testing purpose, this is needed. At least until we have minikube release with kubernetes/minikube#10217 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
|
This change looks good to me 👍 I do not know why GitHub CI failed to build the test-iso, a local build worked and includes the /assign @sharifelgamal |
For rbd-nbd testing purpose, this is needed. At least until we have minikube release with kubernetes/minikube#10217 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
|
@spowelljr can we rerun now? |
|
@pkalever Running the build now |
|
@pkalever The build failed, it uploaded some logs you can take a look at. There was a PR that recently ran where the build was successful (https://github.com/kubernetes/minikube/runs/1864676047?check_suite_focus=true) so I'm not sure at this point if this is a server issue or caused by the PR. |
|
Hi @spowelljr! A local build worked fine for me. Could you restart the failed test maybe? Thanks! |
|
@nixpanic I re-ran the build, the build succeeded this time, the tests failed, but that's a known thing I'm going to work on fixing tomorrow. |
For rbd-nbd testing purpose, this is needed. At least until we have minikube release with kubernetes/minikube#10217 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
|
@spowelljr any updates please? |
|
We're in the process of overhauling our ISO testing framework, so we will retest this once that's ready. |
|
ok-to-build-iso |
|
Hi @pkalever, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
k8s-ci-robot
added
the
needs-rebase
For rbd-nbd testing purpose, this is needed. At least until we have minikube release with kubernetes/minikube#10217 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
removed
the
needs-rebase
|
@sharifelgamal rebased now. Please help set the labels again. |
|
ok-to-build-iso |
|
Hi @pkalever, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
|
kvm2 Driver Times for Minikube (PR 10217): 70.3s 64.0s 62.7s Averages Time Per Log docker Driver Times for Minikube (PR 10217): 30.6s 26.4s 32.4s Averages Time Per Log |
Having NBD module support would enable some of the CSI projects to utilize the NBD based persistent volume requests validation in their automated testing suites. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
|
@sharifelgamal rebased again. Please help set the labels. A couple of months passed already, can someone please take this PR to Merged, at Ceph-csi we are eagerly waiting on these changes, please help. |
|
ok-to-build-iso |
|
Hi @pkalever, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
|
kvm2 Driver Times for Minikube (PR 10217): 64.5s 67.2s 65.7s Averages Time Per Log docker Driver Times for Minikube (PR 10217): 27.5s 27.0s 27.0s Averages Time Per Log |
|
@sharifelgamal @medyagh can you please tell me what are we waiting on ? |
|
My apologies @pkalever, our ISO testing infrastructure is still new and silently failed while testing your ISO. It's still important to us that we test this PR, since ISO changes have bitten us in the past when they were merged untested. I'm going to rebuild this test ISO, then wait for the KVM tests to come back. If they look good, we'll merge this PR ASAP. Sorry again for the delay. |
|
ok-to-build-iso |
|
Hi @pkalever, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
|
kvm2 Driver Times for Minikube (PR 10217): 36.2s 17.5s 29.0s Averages Time Per Log |
|
Quick update here, there's an issue with our ISO build that's not related to this PR. We need to fix that first, then we will retest this. |
|
ok-to-build-iso |
|
Hi @pkalever, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further. |
|
kvm2 Driver Times for Minikube (PR 10217): 28.7s 17.6s 21.2s Averages Time Per Log |
|
Alright, the tests look good. Thanks again for your patience here. Sorry it took so long. |
For rbd-nbd testing purpose, this is needed. At least until we have minikube release with kubernetes/minikube#10217 Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Having NBD module support would enable some of the CSI projects to utilize
the NBD based persistent volume requests validation in their automated
testing suites.
Example, we need it at the ceph-csi project.
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>