Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote OpenAPI V3 to GA #116235

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Promote OpenAPI V3 to GA #116235

merged 1 commit into from
Mar 8, 2023

Conversation

Jefftree
Copy link
Member

@Jefftree Jefftree commented Mar 2, 2023 •
edited by k8s-ci-robot
Loading

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promoted `OpenAPIV3` to GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/triage accepted
/cc @lavalamp @deads2k @apelisse

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 2, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 2, 2023
@apelisse
Copy link
Member

apelisse commented Mar 3, 2023

Looks good to me, thanks

@Jefftree
Copy link
Member Author

Jefftree commented Mar 3, 2023

/retest

@Jefftree Jefftree changed the title [WIP] Promote OpenAPI V3 to GA Promote OpenAPI V3 to GA Mar 3, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2023
@rjsadow
Copy link
Contributor

rjsadow commented Mar 6, 2023

/release-note-edit

release-note Promoted `OpenAPIV3` to GA

@Jefftree
Copy link
Member Author

Jefftree commented Mar 7, 2023

/assign @lavalamp @deads2k

@lavalamp
Copy link
Member

lavalamp commented Mar 7, 2023

I'll approve and let @deads2k lgtm?

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2023
@deads2k
Copy link
Contributor

deads2k commented Mar 8, 2023

Glad to see this wrapping up.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5871dc68451eedff8dd4c93d974e3eebb0ce42a0

@k8s-ci-robot k8s-ci-robot merged commit 4a89664 into kubernetes:master Mar 8, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 8, 2023
@Jefftree Jefftree mentioned this pull request Mar 10, 2023
Closed
13 tasks
@Jefftree Jefftree deleted the oas-ga branch March 21, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@deads2k deads2k Awaiting requested review from deads2k

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@lavalamp lavalamp

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
6 participants
@Jefftree @apelisse @rjsadow @lavalamp @k8s-ci-robot @deads2k