-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCM - service controller] Remove schedulability predicate for LB set #111691
[CCM - service controller] Remove schedulability predicate for LB set #111691
Conversation
@alexanderConstantinescu: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @alexanderConstantinescu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-kind bug |
/ok-to-test |
/kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderConstantinescu, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind regression
What this PR does / why we need it:
PR #109706 re-added the schedulability predicate to the node sync path, causing nodes to be removed from the LB set if any node goes unschedulable. This doesn't seem to be correct however, specifically: it seems it was removed with #90823 which listed a production outage caused by the fact that we were syncing LBs as a cause by the schedulability constraint changing on a set of nodes. #90823 mentioned:
Which will most certainly be the case again after #109706 since any node going unschedulable will be removed from the LB set.
The PR that added the schedulability predicate to the "update predicates" was: #90769, but it didn't list any good reasons for doing so...given this new information it seems the reverse holds true, we should not be removing nodes from the LB set because of this attribute, and we should most likely not even care about this attribute when syncing updates to nodes.
This PR thus removes that predicate altogether.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I am unsure of if we want this PR, or just revert #109706 at this point. But posting this here for efficiency's sake.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @thockin
/sig network
/sig cloud-provider