kinder: use "--config" for kubeadm "reset" and "upgrade" #3086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neolit123
added
priority/important-soon
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
|
/hold for review |
k8s-ci-robot
added
the
do-not-merge/hold
When executing "kubeadm reset" or "kubeadm upgrade", if the kubeadm version is 1.31 (or pre-release) pass the "--config" flag with the v1beta4 kinds. Else, continue to call the flags for a given command. Additionally: - Call "kubeadm upgrade diff" on the primary CP node after calling "upgrade plan". - Fallback to the /kinder/upgrade/version during upgrade if the provided version is different.
neolit123
force-pushed
the
1.31-enable-v1nbeta4-in-kinder
branch
from
4bdf7a3
to
fa5ac66
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing "kubeadm reset" or "kubeadm upgrade", if the kubeadm version is 1.31 (or pre-release) pass the "--config" flag with the v1beta4 kinds. Else,
continue to call the flags for a given command.
Additionally:
includes some smaller improvements like printing a config that is prepared for a command on multiple lines.
xref #2890