-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coredns should not be running on master by default #5917
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @bhegazy. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bhegazy we tend to lean more towards the configs used by kubeadm. Also at this point we would have to be very careful about this change so that we don't break configs for anyone that may be relying on coreDNS being deployed on the masters, so we most likely don't want to just outright remove it. At this point if someone does not want CoreDNS deployed to their masters we'd have to make this configurable and most likely leave the default such that it is still deployed to the masters. |
@rdrgmnzs You're absolutely right, I have requested this change due to my |
So it's not actually the kubeadm configs, but the GCE kube-up configs - they are the ones that are very heavily tested. The file seems to be here: https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/dns/coredns/coredns.yaml.in But ... I actually agree with you - there's no reason to run CoreDNS on the master, and we didn't run kube-dns on the master. I'm going to open an issue upstream with kubernetes to see what the logic is. |
Raised upstream in kubernetes/kubernetes#70851 - it will be good to see what they say. This does seem like a change from the kube-dns behaviour. |
Upstream seemed to agree, and I think it will be very surprising to people if this behaves differently to kube-dns. Thanks @bhegazy /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bhegazy, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is awesome Thanks @justinsb |
CoreDNS can be scheduled on masters.
The masters are busy enough and coredns shouldn't be running there as well
I have followed coredns/deployment#50