Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable containerd test-handler runtimeclass for k/k e2e tests #16056

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 24, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 24, 2023
Makefile Outdated Show resolved Hide resolved
@upodroid
Copy link
Member Author

/test pull-kops-kubernetes-e2e-cos-gce
/test pull-kops-kubernetes-e2e-cos-gce-serial

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2023
@upodroid
Copy link
Member Author

/test pull-kops-kubernetes-e2e-cos-gce-serial

@hakman
Copy link
Member

hakman commented Nov 1, 2023

@upodroid Is this still needed with #16067 being merged?

@upodroid
Copy link
Member Author

upodroid commented Nov 1, 2023

We do. Fixed the diff

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 1, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2023
@justinsb
Copy link
Member

I think it's a cobra / viper bug. It doesn't allow for quotes in a string slice var... I think we may be able to work around by using our own string slice parser in cobra, I'll take a look

@justinsb
Copy link
Member

Ah, and it's been reported upstream but not fixed: spf13/pflag#370

@justinsb
Copy link
Member

Hoping that #16125 will allow for writing this naturally e.g.

go run ./cmd/kops create cluster foo.k8s.local --zones us-east-2a --set 'cluster.spec.containerd.configAdditions=plugins."io.containerd.grpc.v1.cri".containerd.runtimes.test-handler.runtime_type=io.containerd.runc.v2' 

@upodroid
Copy link
Member Author

/test pull-kops-kubernetes-e2e-cos-gce-serial

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 23, 2023

@upodroid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-kubernetes-e2e-cos-gce b5a64a9 link false /test pull-kops-kubernetes-e2e-cos-gce
pull-kops-kubernetes-e2e-cos-gce-serial 99b5fdf link false /test pull-kops-kubernetes-e2e-cos-gce-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 27, 2023
@upodroid
Copy link
Member Author

This is ready to be merged now @hakman

tests/e2e/pkg/kops/state.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 27, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit dbfe8ae into kubernetes:master Nov 27, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants