Support old restart policy in compose v3 #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
LGTM |
surajnarwade
reviewed
Mar 6, 2018
| restart: "unless-stopped" | ||
| environment: | ||
| GITHUB: surajssd | ||
|
|
There was a problem hiding this comment.
@surajnarwade updated! thanks!
hangyan
force-pushed
the
support-old-restart-policy
branch
from
0dd7126
to
ca53676
Compare
|
@hangyan one last thing, can you please add documentation stating that we are converting |
hangyan
force-pushed
the
support-old-restart-policy
branch
from
ca53676
to
acfab6b
Compare
|
@surajnarwade thanks, I will remeber this in the feature PRs. |
cdrage
requested changes
Mar 6, 2018
pkg/loader/compose/v3.go
Outdated
| if composeServiceConfig.Deploy.RestartPolicy != nil { | ||
| serviceConfig.Restart = composeServiceConfig.Deploy.RestartPolicy.Condition | ||
| } | ||
| if serviceConfig.Restart == "unless-stopped" { | ||
| log.Warnf("Restart policy 'unless-stopped in service %s is not supported, convert it to 'always'", name) |
There was a problem hiding this comment.
missing a ' around unless-stopped
hangyan
force-pushed
the
support-old-restart-policy
branch
from
acfab6b
to
723bd0f
Compare
|
Awesome! Tests pass and this looks great to me 👍 merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #876