Fix unset env bug for v3 compose #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
|
Tests pass... is it possible to add a test? If not, I could quickly write one up 👍 |
cdrage
approved these changes
Feb 7, 2018
|
Sure, I will add some unit test
?? Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Charlie Drage <notifications@github.com>
Sent: Wednesday, February 7, 2018 9:04:56 PM
To: kubernetes/kompose
Cc: Hang Yan; Author
Subject: Re: [kubernetes/kompose] Fix unset env bug for v3 compose (#926)
@cdrage approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#926 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ADwax03mEKHn0ehjBdQ6_ExJhehg_Jijks5tSZ94gaJpZM4R8GtD>.
|
hangyan
force-pushed
the
fix-v3-unset-env
branch
from
fc49a4f
to
0ef015d
Compare
k8s-ci-robot
added
size/L
|
@cdrage I have add some tests and check the docker-compose doc and find that my previous code is not correct. Link: https://docs.docker.com/compose/compose-file/#environment. I have rewrite the logic, please help me review it |
surajnarwade
approved these changes
Feb 8, 2018
|
These LGTM. Thanks for the contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #918