Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push image without authentication #913

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

coodix
Copy link
Contributor

@coodix coodix commented Jan 25, 2018

For fixing issue #911

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 25, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 25, 2018
@cdrage
Copy link
Member

cdrage commented Jan 25, 2018

@coodix does this actually work on MacOS?

@coodix
Copy link
Contributor Author

coodix commented Jan 25, 2018

@cdrage , yes, checked with local private repository which was set up it with:
docker run -d -p 5000:5000 --restart=always --name registry registry:2

And pushed image to localhost:5000.

log.Warn(errors.Wrap(err, "Unable to retrieve .docker/config.json authentication details. Check that 'docker login' works successfully on the command line."))
}

if credentials == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a comment here saying TODO: refactor as well as detail the error (add the fsouza/dockerclient-go) issue? Otherwise, this code LGTM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is that it would be nice to have this approach (try push without authentication) cause when you use local private repo it doesn't actually require login (via docker login command) there before accessing it.

If you thing kompose should always expect available credentials in config.json I can add the comment "TODO: refactor as well as dockerclient-go starts retrieve credentials from osxkeychain (add the fsouza/dockerclient-go) issue".

What do you think?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 26, 2018
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, this LGTM 👍

@cdrage cdrage merged commit 32b2659 into kubernetes:master Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants