fix issue 1778 update1

[sosan]

in case /run/secrets/MARIADB_PASSWORD and secrets: MARIADB_PASSWORD are in uppercase, reformat the value of MARIADB_PASSWORD to mariadb-password. Also, reformat the secretconfig of the secrets. also getSecretPathsLegacy returns secretSubPath.

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

updated fix to contemplate mays in secrets:

version: "3.9"
services:
  database:
    image: mariadb:11
    deploy:
      replicas: 1
    environment:
      MARIADB_ROOT_PASSWORD_FILE: /run/secrets/MARIADB_PASSWORD
    secrets:
      - MARIADB_PASSWORD
secrets:
  MARIADB_PASSWORD:
    file: "./mariadb-password.txt"

Which issue(s) this PR fixes:

Fixes #1778

Special notes for your reviewer:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, sosan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cdrage]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ghost]

This caused a regression in our Compose file:

services:
  a:
    image: alpine:3.19
    command: ["cat", "/etc/hello_world.yaml"]
    secrets:
      - source: hello-world
        target: /etc/hello_world.yaml
secrets:
  hello-world:
    file: config/hello_world.yaml

Now, I am unable to cat /etc/hello_world.yaml.

[ghost]

I would implement this solution differently, without touching any environments:

1. If target is specified, only ever transform the source field.
2. If target is not specified, fill it in as /run/secrets/{source_before_transform}.

The output of the original Compose by @sosan should be:

    spec:
      containers:
        - env:
            - name: MARIADB_ROOT_PASSWORD_FILE
              value: /run/secrets/MARIADB_PASSWORD
          image: mariadb:11
          name: database
          volumeMounts:
            - mountPath: /run/secrets
              name: mariadb-password
              subPath: MARIADB_PASSWORD
      restartPolicy: Always
      volumes:
        - name: mariadb-password
          secret:
            items:
              - key: mariadb-password
                path: MARIADB_PASSWORD
            secretName: mariadb-password

[cdrage]

I would implement this solution differently, without touching any environments:

1. If target is specified, only ever transform the source field.

2. If target is not specified, fill it in as /run/secrets/{source_before_transform}.

The output of the original Compose by @sosan should be:

    spec:

      containers:

        - env:

            - name: MARIADB_ROOT_PASSWORD_FILE

              value: /run/secrets/MARIADB_PASSWORD

          image: mariadb:11

          name: database

          volumeMounts:

            - mountPath: /run/secrets

              name: mariadb-password

              subPath: MARIADB_PASSWORD

      restartPolicy: Always

      volumes:

        - name: mariadb-password

          secret:

            items:

              - key: mariadb-password

                path: MARIADB_PASSWORD

            secretName: mariadb-password

Hi! Could you open an issue so we make sure that we track this?