Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(1815): add trademarks link ref to linux foundation #1816

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

martinjirku
Copy link
Contributor

@martinjirku martinjirku commented Jan 27, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This PR solves the trademark criteria on CLOMonitor.

Which issue(s) this PR fixes:

Fixes #1815

Special notes for your reviewer:

This PR includes incorect css - missing :: margin-bottom: 0px !important;

image

Signed-off-by: Martin Jirku <martin@jirku.sk>
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2024
@kundan2707
Copy link
Contributor

@martinjirku can you share preview of file after changes ?

@martinjirku
Copy link
Contributor Author

@martinjirku can you share preview of file after changes ?

Sure, but what do you mean by "file" ? I've included the footer screenshot in the first comment. Is there speciflic page and screensize you want to see?

@kundan2707
Copy link
Contributor

@martinjirku yes i wanted preview after changes only.
I was not sure if image is preview after change or not.
Thanks

@kundan2707
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2024
@cdrage
Copy link
Member

cdrage commented Feb 1, 2024

Thanks @martinjirku !

@kundan2707 you can view the preview from following the README.md in the docs folder.

LGTM!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, martinjirku

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit e869594 into kubernetes:main Feb 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website does not have the correct trademark disclaimer
4 participants