Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recommend to use 'go install @latest" for Go #1488

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Mar 14, 2022

PR changes from go get to go install since the go get method is deprecated per https://go.dev/doc/go-get-install-deprecation.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 14, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 14, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dmitris / name: Dmitry Savintsev (3a431dd)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 14, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @dmitris!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2022
@kadel
Copy link
Member

kadel commented Mar 15, 2022

Hi, @dmitris thank you for contributing to kompose.
As a first-time contributor, you first need to sign CNCF CLA. You can find more info in #1488 (comment)

@dmitris
Copy link
Contributor Author

dmitris commented Mar 15, 2022

Hi, @dmitris thank you for contributing to kompose. As a first-time contributor, you first need to sign CNCF CLA. You can find more info in #1488 (comment)

thanks @kadel - going now through the motions regarding the corporate permission and the CLA

@sergeyshevch
Copy link
Member

@dmitris Is there any progress?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2022
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing /retitle in a comment.

When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 18, 2022
@dmitris
Copy link
Contributor Author

dmitris commented Aug 18, 2022

@dmitris Is there any progress?

@sergeyshevch sorry for the delay, the CLA is completed now.

@kadel kadel removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Aug 23, 2022
@kadel
Copy link
Member

kadel commented Aug 29, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmitris, kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2022
@kadel kadel removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 29, 2022
@kadel
Copy link
Member

kadel commented Aug 29, 2022

/override lint

@dmitris
Copy link
Contributor Author

dmitris commented Sep 20, 2022

@kadel could you re-trigger the build, would it help to get over the golangci-lint build failure? Thanks.

@kadel
Copy link
Member

kadel commented Sep 26, 2022

I'm not sure what is going on with golangci-lint and why it is complaining about unrelated changes :-( I'm merging this PR manullay. Later this week, I should have some time to clean up CI.

@kadel kadel merged commit a4413b2 into kubernetes:master Sep 26, 2022
@dmitris dmitris deleted the patch-1 branch September 26, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants