Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TLS does not get updated when changed #176

Merged
merged 1 commit into from
Jan 26, 2017
Merged

Fix TLS does not get updated when changed #176

merged 1 commit into from
Jan 26, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 26, 2017

fixes #171

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 26, 2017
@aledbf aledbf added the nginx label Jan 26, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf changed the title Fix TLS does not get updated when changed WIP: Fix TLS does not get updated when changed Jan 26, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 44.418% when pulling 8ae97650d40039d684a49972019f87220d9409cf on aledbf:fix-ssl-update into 0f7102a on kubernetes:master.

@aledbf aledbf changed the title WIP: Fix TLS does not get updated when changed Fix TLS does not get updated when changed Jan 26, 2017
@aledbf
Copy link
Member Author

aledbf commented Jan 26, 2017

@rikatz please check if this PR solves the issue (I followed your steps and now works as expected)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 44.382% when pulling bc810d8 on aledbf:fix-ssl-update into 0f7102a on kubernetes:master.

@rikatz
Copy link
Contributor

rikatz commented Jan 26, 2017

@aledbf It works now!!! Ready to merge, captain :)

@rikatz
Copy link
Contributor

rikatz commented Jan 26, 2017

@aledbf An update. After this, my PR #170 also works fine. But I'll wait until you merge this one, so I can run some better tests

@aledbf aledbf merged commit b134472 into kubernetes:master Jan 26, 2017
@aledbf
Copy link
Member Author

aledbf commented Jan 26, 2017

@rikatz thanks for testing.

@aledbf aledbf deleted the fix-ssl-update branch February 2, 2017 11:15
@Velan987 Velan987 mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. nginx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid TLS does not get updated when changed
5 participants
@aledbf @k8s-reviewable @coveralls @rikatz @k8s-ci-robot