Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects the behaviour of default-ssl-certificate #170

Closed
wants to merge 19 commits into from

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Jan 24, 2017

This PR corrects the behaviour of default-ssl-certificate

WARNING - There is a breaking change here. Now the directive default-ssl-certificate is mandatory, and also it's existence. If there's no default-ssl-certificate the ingress controller deployment will fail.

When the Ingress Controller starts, it tries to fetch a default SSL Certificate to be used on the default backend service.

Also, when a user configures a ingress controller with the 'tls' directive, but doesn't specify the secret to be used, the default will be used instead.

This PR is related to issue #163 and also is a proposal.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 43.071% when pulling 725f45b on rikatz:defaultsslcert into 40406b1 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Jan 24, 2017

@rikatz please do not make --default-ssl-certificate a mandatory flag and reuse the logic to use the snake-oil-certificate

@rikatz
Copy link
Contributor Author

rikatz commented Jan 24, 2017

@aledbf Tks for the answer. Will see another way to implement this :)

@rikatz
Copy link
Contributor Author

rikatz commented Jan 25, 2017

@aledbf This is WIP. Will continue this on thursday. I don't know if the last changes I've made are enough for this self generated certificate.

I've noticed that Ingress Controller doesn't follow cert updates when you change the 'TLS' directive and so, don't know if this is a bug inserted by me with the modifications, or if it's something pre-existent.

I'll try with the original Master branch the same tests I did here, to see if this still happens.

@rikatz
Copy link
Contributor Author

rikatz commented Jan 25, 2017

OK, so the behaviour is the same without this PR.
Opened the issue #171 , as I'm not able (a poor golang developer here ;P ) to correct this one.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 43.027% when pulling 07ff578 on rikatz:defaultsslcert into 40406b1 on kubernetes:master.

@rikatz
Copy link
Contributor Author

rikatz commented Jan 26, 2017

@aledbf Closing this PR. Did some mess here. Going to open another one, only with the right updates.

@rikatz rikatz closed this Jan 26, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+1.003%) to 44.196% when pulling 9b26b9a on rikatz:defaultsslcert into 40406b1 on kubernetes:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants