Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and godebug to compare structs #128

Merged
merged 2 commits into from
Jan 13, 2017
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 13, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf added nginx enhancement and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 13, 2017
@aledbf aledbf requested a review from justinsb January 13, 2017 13:27
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 42.522% when pulling 64a5e43 on aledbf:add-tests into 793672d on kubernetes:master.

@justinsb
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

@justinsb: you can't LGTM a PR unless you are an assignee.

In response to this comment:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aledbf aledbf merged commit 2eb9ab5 into kubernetes:master Jan 13, 2017
@aledbf
Copy link
Member Author

aledbf commented Jan 13, 2017

@justinsb thanks!

@aledbf aledbf deleted the add-tests branch February 2, 2017 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants