Add condition of enqueue and unit test cases for task.Queue #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
aledbf
reviewed
Jan 7, 2017
| @@ -51,6 +51,11 @@ func (t *Queue) Run(period time.Duration, stopCh <-chan struct{}) { | |||
|
|
|||
| // Enqueue enqueues ns/name of the given api object in the task queue. | |||
| func (t *Queue) Enqueue(obj interface{}) { | |||
| if t.IsShuttingDown() { | |||
aledbf
reviewed
Jan 7, 2017
| q.Shutdown() | ||
| s := q.IsShuttingDown() | ||
| if !s { | ||
| t.Fatalf("queue shoule be shutdown") |
|
/lgtm |
|
@aledbf: you can't LGTM a PR unless you are an assignee. In response to this comment:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@chentao1596 Thanks! |
Merged
haoqing0110
pushed a commit
to stolostron/management-ingress
that referenced
this pull request
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, all the codes are related with task.Queue, so i merge them into one PR with two commits.
For the first commit:
I think it's necessary to add checking action before enqueue, because:
1) no need to execute this codes before "t.queue.Add(key)" if queue has been closes
2) log is needed if failed to enqueue
For the second commit:
add unit test cases
thank you!