WIP: Add function to allow custom values in Ingress status

[aledbf]

ping @bigkraig

[k8s-reviewable]

This change is 

[bigkraig]

👍 I am able to configure the ingress address now. thanks!!

[aledbf]

/retest

[bigkraig]

@aledbf hold off on merging this. I am looking into an issue that occurs when I return nil. Rather than having the address set to the IPs of the nodes, it is set to the most recent return of UpdateIngressStatus

I0717 12:05:22.454378   21011 log.go:48] [ALB-INGRESS] [prd426-prom-alertmanager] [INFO]: 1 internal-dev-cf98cfacafd7a77-1375784819.us-east-1.elb.amazonaws.com
I0717 12:05:22.454655   21011 log.go:62] [ALB-INGRESS] [prd354-raphaeld-quaffing-joey-exampleapp] [ERROR]: No ALB hostnames for ingress
I0717 12:05:22.454667   21011 status.go:317] updating Ingress prd354-raphaeld/quaffing-joey-exampleapp status to [{ internal-dev-cf98cfacafd7a77-1375784819.us-east-1.elb.amazonaws.com}]

	if len(hostnames) == 0 {
		log.Errorf("No ALB hostnames for ingress", *albIngress.id)
		return nil
	}

	log.Infof("%d %s", *albIngress.id, len(hostnames), hostnames[0].Hostname)
	return hostnames
}

[aledbf]

@bigkraig https://github.com/kubernetes/ingress/pull/985/files#diff-9cef6a58a4eaf42843bd0db5b4a2f018R96

[bigkraig]

@aledbf yeah using that. the function is pretty simple so i am not seeing how this is breaking yet, but something is definitely off. it have gone unnoticed before since i think newIPs was probably always the same.

This is the func I am adding

+// UpdateIngressStatus tracks the ALB hostnames in the ingresses
+func (ac *ALBController) UpdateIngressStatus(ingress *extensions.Ingress) []api.LoadBalancerIngress {
+       albIngress := NewALBIngress(ingress.ObjectMeta.Namespace, ingress.ObjectMeta.Name, *ac.ClusterName)
+
+       i := ac.ALBIngresses.find(albIngress)
+       if i < 0 {
+               log.Errorf("Unable to find ingress", *albIngress.id)
+               return nil
+       }
+
+       var hostnames []api.LoadBalancerIngress
+       for _, lb := range ac.ALBIngresses[i].LoadBalancers {
+               if lb.CurrentLoadBalancer == nil || lb.CurrentLoadBalancer.DNSName == nil {
+                       continue
+               }
+               hostnames = append(hostnames, api.LoadBalancerIngress{Hostname: *lb.CurrentLoadBalancer.DNSName})
+       }
+
+       if len(hostnames) == 0 {
+               log.Errorf("No ALB hostnames for ingress", *albIngress.id)
+               return nil
+       }
+
+       log.Infof("%d %s", *albIngress.id, len(hostnames), hostnames[0].Hostname)
+       return hostnames
+}

[bigkraig]

@aledbf yeah, the problem is here. We lose the original newIPs the first time UpdateIngressStatus is successful.

https://github.com/aledbf/ingress/blob/addcc4639f4024dc7f4ab7124f9744d97a5412a9/core/pkg/ingress/status/status.go#L307

[aledbf]

@bigkraig I am waiting for #994 to fix and merge this PR

[bigkraig]

ping @aledbf any chance we can knock this one out?

[aledbf]

@bigkraig yes, at the end of the day I will update this PR