Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve variable configuration for source IP address #890

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Improve variable configuration for source IP address #890

merged 1 commit into from
Jun 21, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 21, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 21, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf
Copy link
Member Author

aledbf commented Jun 21, 2017

closes #885

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.543% when pulling 85e6d30 on aledbf:simplify-vars into 0aa41ec on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.543% when pulling 85e6d30 on aledbf:simplify-vars into 0aa41ec on kubernetes:master.

@aledbf aledbf mentioned this pull request Jun 21, 2017
Closed
@aledbf aledbf merged commit 4235166 into kubernetes:master Jun 21, 2017
@aledbf aledbf mentioned this pull request Jun 21, 2017
Closed
@aledbf aledbf deleted the simplify-vars branch June 22, 2017 02:02
@aledbf aledbf mentioned this pull request Jun 22, 2017
Closed
@n1koo n1koo mentioned this pull request Jul 24, 2017
Closed
@karanthukral karanthukral mentioned this pull request Aug 9, 2017
Merged
@ykan
Copy link

ykan commented Aug 14, 2018

Why not use proxy_set_header X-Forwaded-For $proxy_add_x_forwarded_for; ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aledbf @k8s-reviewable @coveralls @ykan @k8s-ci-robot