-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to skip the update of Ingress status on shutdown #882
Conversation
@@ -89,6 +89,10 @@ func NewIngressController(backend ingress.Controller) *GenericController { | |||
forceIsolation = flags.Bool("force-namespace-isolation", false, | |||
`Force namespace isolation. This flag is required to avoid the reference of secrets or | |||
configmaps located in a different namespace than the specified in the flag --watch-namespace.`) | |||
|
|||
statusUpdateOnShutdown = flags.Bool("update-status-on-shutdown", true, `Indicates if the | |||
ingress controller should NOT update the Ingress status IP/hostname when the controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This could probably just be should update the Ingress
... i.e. I think "not" is wrong there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
LGTM |
/lgtm |
ElectionID string | ||
UpdateStatus bool | ||
ElectionID string | ||
StatusUpdateOnShutdown bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another nit - I'm not sure if this is exposed anywhere, but it probably should be UpdateStatusOnShutdown
to mirror the flag name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
bf9be4c
to
d6aeecc
Compare
d6aeecc
to
05a976f
Compare
fixes #881