Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add port for plain HTTP to HTTPS redirection #5374

Merged
merged 1 commit into from
Apr 18, 2020
Merged

Add port for plain HTTP to HTTPS redirection #5374

merged 1 commit into from
Apr 18, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 14, 2020 •
edited
Loading

What this PR does / why we need it:

Allow TLS termination in AWS LB (ELB) and fix redirect to https errors.

  1. Download deploy-tls-termination.yaml
  2. Change:
  • VPC CIDR: proxy-real-ip-cidr: XXX.XXX.XXX/XX
  • ACM Certificate ID service.beta.kubernetes.io/aws-load-balancer-ssl-cert: arn:aws:acm:us-west-2:XXXXXXXX:certificate/XXXXXX-XXXXXXX-XXXXXXX-XXXXXXXX

ref: #5360

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #1957
fixes #4265
fixes #314
fixes #2724
fixes #5279
fixes #5051

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@aledbf
Copy link
Member Author

aledbf commented Apr 15, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@aledbf aledbf force-pushed the 2https2 branch 6 times, most recently from 5026408 to 2a6d7c5 Compare April 15, 2020 02:31
@aledbf aledbf removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@aledbf aledbf merged commit 7da08be into kubernetes:master Apr 18, 2020
@aledbf aledbf deleted the 2https2 branch April 22, 2020 16:18
@grifx grifx mentioned this pull request Apr 23, 2020
Closed
@yang-xiaodong yang-xiaodong mentioned this pull request May 6, 2020
Closed
@brsolomon-deloitte brsolomon-deloitte mentioned this pull request Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChiefAlexander ChiefAlexander Awaiting requested review from ChiefAlexander

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
2 participants
@aledbf @k8s-ci-robot