Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit test cases for core/pkg/ingress/controller/annotations #505

Merged
merged 2 commits into from
Mar 27, 2017
Merged

add unit test cases for core/pkg/ingress/controller/annotations #505

merged 2 commits into from
Mar 27, 2017

Conversation

chentao1596
Copy link

Just what like the descriptions of two commits, thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 43.894% when pulling 767591f on chentao1596:annotations_unittest into a7af840 on kubernetes:master.

@aledbf aledbf self-assigned this Mar 27, 2017
@aledbf
Copy link
Member

aledbf commented Mar 27, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2017
@aledbf
Copy link
Member

aledbf commented Mar 27, 2017

@chentao1596 thanks!

@aledbf aledbf merged commit e2c7a53 into kubernetes:master Mar 27, 2017
@chentao1596 chentao1596 deleted the annotations_unittest branch March 28, 2017 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chentao1596 @k8s-reviewable @coveralls @aledbf @k8s-ci-robot @chentao11596