Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log info when endpoints change for a balancer #4120

Merged
merged 1 commit into from
May 26, 2019
Merged

log info when endpoints change for a balancer #4120

merged 1 commit into from
May 26, 2019

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:
See #4023 (comment)

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 26, 2019
@k8s-ci-robot k8s-ci-robot requested review from aledbf and bowei May 26, 2019 03:52
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@dfa7f10). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4120   +/-   ##
=========================================
  Coverage          ?   57.76%           
=========================================
  Files             ?       87           
  Lines             ?     6459           
  Branches          ?        0           
=========================================
  Hits              ?     3731           
  Misses            ?     2296           
  Partials          ?      432

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfa7f10...dc7fa88. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented May 26, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 008822b into kubernetes:master May 26, 2019
@ElvinEfendi ElvinEfendi deleted the lua-balancer-logging branch May 26, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants