-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Offline plugin configuration #3967
[wip] Offline plugin configuration #3967
Conversation
2c014ac
to
b324756
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@ElvinEfendi When do you think this will be merged ? The plugins system is really interesting. |
Hi, it would be great to merge this, as the switch to lua scripts has broken a number of scenarios when using AWS and TCP listeners (#2724 (comment) and #2724 (comment)). This would provide an alternate solution to the problem. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For anyone wanting to use plugin system: here's an article I wrote to describe how you can write ingress-nginx plugin and configure it: https://www.elvinefendi.com/2019/11/22/ingress-nginx-openidc-plugin.html I might resume this PR depending on the feedback we collect. |
This PR has been replaced by #5331 |
@ElvinEfendi: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: