Plugin select deployment using replicaset name #3955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
ElvinEfendi
reviewed
Apr 1, 2019
| if strings.HasPrefix(owner.Name, deployment+"-") { | ||
| return true | ||
| } | ||
| } |
There was a problem hiding this comment.
please extract the checks into their own function with name that represents what it actually checks. Or add inline comments.
There was a problem hiding this comment.
nevermind the comment above is explanatory enough
|
/approve |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, alexkursell, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The
--deploymentflag was recently added to somekubectl ingress-nginxsubcommands in order to specify the deployment we would like to query. The criterion that the plugin was previously using to check if a pod was in a deployment was not actually connected to the deployment name.This PR lets the plugin check whether the deployment name is a prefix of the name of the ReplicaSet that owns the pod, which should actually match the deployment name.