Fix load-balance configmap value #3954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #3954 +/- ##
==========================================
- Coverage 54.25% 54.24% -0.02%
==========================================
Files 83 83
Lines 6163 6161 -2
==========================================
- Hits 3344 3342 -2
Misses 2426 2426
Partials 393 393
Continue to review full report at Codecov.
|
|
/approve |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, alexkursell, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The
load-balanceconfigmap value was being ignored. Additionally, the documentation was out of date. Additionally additionally, there were a bunch of if statements in the upstream construction logic that were always true, so I removed them. An e2e test is also added to check that the configmap value is applied.Which issue this PR fixes : fixes #3929
Special notes for your reviewer: This PR assumes the per-ingress
load-balanceannotation should override the globalload-balanceconfigmap value. If this isn't the case, please tell me so I can edit the PR.