Ingress Fake Certificate generation #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 6, 2017 09:21
…oesn't exists Generates a Self signed certificate for default vhost if the secret doesn't exists modified: core/pkg/ingress/controller/backend_ssl.go modified: core/pkg/ingress/controller/controller.go modified: core/pkg/net/ssl/ssl.go
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@rikatz thanks! |
jcmoraisjr
reviewed
Mar 10, 2017
| @@ -944,9 +956,6 @@ func (ic *GenericController) createServers(data []interface{}, | |||
| servers[host].SSLCertificate = cert.PemFileName | |||
| servers[host].SSLPemChecksum = cert.PemSHA | |||
| } | |||
| } else { | |||
| servers[host].SSLCertificate = defaultPemFileName | |||
| servers[host].SSLPemChecksum = defaultPemSHA | |||
| } | |||
There was a problem hiding this comment.
This was removed due to a request from @bprashanth to not assign the default certificate on misconfigured ingresses.
Instead, I'm going to create a new ConfigMap to make this behaviour configurable (a heroku like), and it will be an admin choice to enable or not this.
There was a problem hiding this comment.
@bprashanth PR #459 adds if tlsSecretName == "" before looking for a secret. Could this be changed to "use the default secret" instead a warning? This would fix a misbehavior on haproxy ingress. Note that this change doesn't assign the default cert on a misconfigured ingress.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the problem reported in #191
It generates a new Fake Cert, instead of using the snake oil.
Once the Fake Cert is generated, it's not created anymore until someone erases it.
Also it improves the secrets enqueing by removing some wrong code that wasn't downloading the other TLS Secrets.
A final change in this PR is inserting a 'os.Remove' in the Temporary Pem File generation, so when an error occurs the files does not fill the filesystem
This PR substitutes the #194.
cc @aledbf