Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade openresty/lua-resty-balancer #3809

Merged

Conversation

ArchangelSDY
Copy link
Contributor

What this PR does / why we need it:

This fixes bug in chash:reinit which prevents endpoints from being updated correctly.

See openresty/lua-resty-balancer#25

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2019
@aledbf
Copy link
Member

aledbf commented Feb 25, 2019

@ArchangelSDY please increase the version to 0.79 in images/nginx/Makefile

This fixes bug in chash:reinit which prevents endpoints from being
updated correctly.

See openresty/lua-resty-balancer#25
@ArchangelSDY
Copy link
Contributor Author

@aledbf updated.

@aledbf
Copy link
Member

aledbf commented Feb 25, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2019
@aledbf
Copy link
Member

aledbf commented Feb 25, 2019

@ArchangelSDY thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ArchangelSDY

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2019
@aledbf
Copy link
Member

aledbf commented Feb 25, 2019

I will update the ingress controller image after this PR is merged and the new image is available in quay.io

@ArchangelSDY
Copy link
Contributor Author

Cool, thanks @aledbf !

@k8s-ci-robot k8s-ci-robot merged commit 88c2909 into kubernetes:master Feb 25, 2019
@ElvinEfendi
Copy link
Member

ElvinEfendi commented Feb 25, 2019

@ArchangelSDY first thanks for fixing this!

Did you see any impact of this on ingress-nginx? I looked into this and only impact I could see is that ingress-nginx would unnecessarily keep calling

self.instance:reinit(nodes)
because
local changed = not util.deep_compare(self.instance.nodes, nodes)
would always be true. But no impact on load balancing logic.

@ArchangelSDY
Copy link
Contributor Author

@ElvinEfendi Here is the case we encountered:

  1. First we have two backends A and B.
  2. For some reason B failed readiness probe, so self.instance.nodes != nodes. Then reinit was called correctly.
  3. B comes back online afterwards. But now self.instance.nodes == nodes since self.instance.nodes was not correctly updated. So reinit will not be called. B will never be added back.

@ElvinEfendi
Copy link
Member

@ArchangelSDY I see, that makes sense. I think this is also the root cause of some session affinity related issues where users were complaining that load balancing is not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants