Remove session-cookie-hash annotation #3743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
@alexkursell @ElvinEfendi to avoid problems in the next release, I will add a deprecation notification. We can remove the annotation after the next release. I think we can release 0.23 after NGINX 1.15.9 (next Tuesday), like next Friday. |
|
@aledbf Makes sense. This definitely isn't urgent or anything. |
aledbf
added
the
do-not-merge/blocked-paths
aledbf
removed
the
do-not-merge/blocked-paths
|
@alexkursell please rebase and this lgtm |
alexkursell
force-pushed
the
remove-session-cookie-hash
branch
from
3d7744f
to
d3ac73b
Compare
|
@aledbf Rebased. |
|
/approve |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, alexkursell, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Gacko
added a commit
to giantswarm/docs
that referenced
this pull request
Nov 23, 2023
Gacko
added a commit
to giantswarm/docs
that referenced
this pull request
Nov 27, 2023
Gacko
added a commit
to giantswarm/docs
that referenced
this pull request
Nov 28, 2023
Gacko
added a commit
to giantswarm/docs
that referenced
this pull request
Nov 28, 2023
* Configuration: Prepend `nginx` to annotations. * Configuration: Remove `nginx.ingress.kubernetes.io/add-base-url`. Deprecated: kubernetes/ingress-nginx#3174 * Configuration: Remove `nginx.ingress.kubernetes.io/session-cookie-hash`. Deprecated: kubernetes/ingress-nginx#3743 * Configuration: Bump `last_review_date`. * Multiple Ingress NGINX Controllers: Remove deprecated `controller.ingressClass`. * Multiple Ingress NGINX Controllers: Remove wildcard from `controller.service.subdomain`. * Multiple Ingress NGINX Controllers: Migrate `configmap` to `controller.config`. * Multiple Ingress NGINX Controllers: Bump `last_review_date`. * Service Type LoadBalancer: Make `service.beta.kubernetes.io/aws-load-balancer-internal` a boolean. * Service Type LoadBalancer: Make `service.beta.kubernetes.io/aws-load-balancer-access-log-emit-interval` a string. * Service Type LoadBalancer: Move `Other AWS ELB configuration options`. * Service Type LoadBalancer: Document Martian Packets when using internal AWS Network Load Balancers. * Service Type LoadBalancer: Document Health Checks failing when using PROXY protocol and `externalTrafficPolicy: Local`. * Service Type LoadBalancer: Document Security Group configuration on internal AWS Network Load Balancers. * Service Type LoadBalancer: Bump `last_review_date`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR removes the
nginx.ingress.kubernetes.io/session-cookie-hashannotation completely, as it is essentially useless. The hash function was being used only to hash a random value to make a key to be set as the session cookie value. Why hash the random value at all?This annotation appears to be a vestige from when we used https://bitbucket.org/nginx-goodies/nginx-sticky-module-ng
see discussion at #3740 (comment)