Remove flag sort-backends

[aledbf]

What this PR does / why we need it:

The flag sort-backends was required to avoid reloads because of the change in the order of the upstream servers in the generated nginx.conf file. This is not an issue anymore since the use of lua.

[ElvinEfendi]

What is the actual cause of endpoints changing their order? If that cause still exists without sorting the upstreams we will now POST the payload to Lua endpoint unnecessarily, while this is better than reload it is still not good.

Again if the actual cause (I don't know what it is) still exists I'd just remove the flag and always sort.

[aledbf]

What is the actual cause of endpoints changing their order?

The iteration in the go template

If that cause still exists without sorting the upstreams we will now POST the payload to Lua endpoint unnecessarily, while this is better than reload it is still not good.

That will not happen because to trigger a reload we check the equality of the configuration, thing that doesn't need the list to be ordered.

[aledbf]

Also, the default value is false, so no change in the default behavior ;)

[ElvinEfendi]

ingress-nginx/internal/ingress/types_equals.go

Line 32 in 2c3ce07

for _, c1b := range c1.Backends {

answers my question.

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ElvinEfendi,aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ElvinEfendi]

you are already deleting it, why mark it as deprecated now?

deprecated tells me it is still there and working just deprecated i.e will be dropped in next release