lua randomseed per worker #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
lgtm 👍 |
zrdaley
reviewed
Dec 19, 2018
| @@ -0,0 +1,9 @@ | |||
| describe("lua_ingress", function() | |||
| it("patches math.randomseed to not be caled more than once per worker", function() | |||
zrdaley
reviewed
Dec 19, 2018
|
|
||
| std = { | ||
| read_globals = { math = { fields = { "randomseed" } } } | ||
| } |
There was a problem hiding this comment.
I think this file needs to be rewritten to something like:
std = {
globals = {'_TEST', 'ngx_lua'},
read_globals = { math = { fields = { "randomseed" } } }
}
exclude_files = {'./rootfs/etc/nginx/lua/test/**/*.lua'}
There was a problem hiding this comment.
@zrdaley it looks like globals, read_globals, std are all same level, so can not be nested like you suggested. I had to use ignore per file.
ElvinEfendi
force-pushed
the
lua-randomseed-per-worker
branch
from
bafd553
to
1666fdc
Compare
ElvinEfendi
commented
Dec 20, 2018
| @@ -3,3 +3,8 @@ globals = { | |||
| '_TEST' | |||
| } | |||
| exclude_files = {'./rootfs/etc/nginx/lua/test/**/*.lua'} | |||
| files["rootfs/etc/nginx/lua/lua_ingress.lua"] = { | |||
| ignore = { "122" }, | |||
There was a problem hiding this comment.
The code is taken from
rootfs/etc/nginx/lua/lua_ingress.lua:5:1: (W122) setting read-only field randomseed of global math
1666fdc
to
2f4d9ba
Compare
ElvinEfendi
force-pushed
the
lua-randomseed-per-worker
branch
from
2f4d9ba
to
4896b06
Compare
|
/assign @aledbf |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously we have switched to explicitly seeding PRNG for tests and this PR does it for production code. I've also patched
math.randomseedso that individual modules can not re-seed PRNG since that can potentially affect randomness. And the reason why I'm seeding per worker rather than ininit_by_luais because otherwise every worker would be seeded with the same seed.lua_ingress.luawill be used for general things such as this. And eventually I'd like it to be the only entry point to Lua code that executes everything else.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: