dynamic certificate mode should support widlcard hosts #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
ElvinEfendi
commented
Nov 29, 2018
| local value = pair:sub(i + 1, -1) | ||
| return name, value | ||
| end | ||
| end |
There was a problem hiding this comment.
this function isn't being used anywhere
k8s-ci-robot
added
the
approved
ElvinEfendi
force-pushed
the
support-wildcard-host
branch
from
52a4974
to
22690aa
Compare
ElvinEfendi
force-pushed
the
support-wildcard-host
branch
from
22690aa
to
7ae2583
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When an ingress defines wildcard host dynamic certificate does not work properly. For example when an ingress has
host: "*.example.com"and a wildcard certificate supporting that, requests to i.e sub.example.com won't work because dynamic certificate serving module currently does not know how to fetch certificate for that. This PR changes the module to first look up the certificate using the given SNI (sub.example.comin the example) if no certificate exists, it will then look up for certificate by replacing first part of domain until a.with*and will try again (*.example.comin the example).Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: